Generalise cache getOrElse

[jackpf]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @jackpf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the caching mechanism to introduce a more flexible and generalized getOrElse method. By leveraging a new Cacheable type class, the cache can now seamlessly handle values wrapped in various monadic contexts such as Try or Option, reducing code duplication and improving the extensibility of the caching utility. This change streamlines how cached data is retrieved and stored across different parts of the application.

Highlights

• Generalized Cache getOrElse Method: The Cache utility's getOrElse method has been refactored to be generic, allowing it to work with different wrapper types like Try or Option through a new Cacheable type class.
• Introduction of Cacheable Type Class: A new Cacheable trait and its implicit instances (for Option, Try, and a default for any type) have been added to provide a unified mechanism for wrapping and unwrapping cached values.
• Simplified OSMService Cache Usage: The OSMService now utilizes the generalized cache.getOrElse method, replacing the more specific cache.getOrElseTry, which streamlines its interaction with the caching layer.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a great refactoring by generalizing the getOrElse method in the Cache utility. Using a Cacheable typeclass is a clean and extensible way to support different container types like Try and Option. The changes make the cache more reusable and reduce code duplication.

I have one suggestion to make the implementation of the onComplete callback in the new getOrElse method more concise and idiomatic.