feat: Implement activity-based wallet discovery with gap limit algorithm #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements BIP-44 compliant activity-based wallet discovery to find ALL wallets with activity when importing from seed phrase, instead of just checking the first 20 addresses. ## Changes ### Core Implementation - Add GAP_LIMIT (20) and MAX_DISCOVERY_ADDRESSES (1000) constants - Implement gap limit discovery algorithm in activityDetection.ts - Support batched parallel checking for performance optimization - Add progress callback support for UI integration ### Blockchain-Specific Activity Checkers - Solana: Check SOL balance + transaction history - Ethereum: Check ETH balance + nonce (tx count) - Both include caching for efficiency ### API Updates - Export ethereumIndexed() for Ethereum path generation - Add getStandardDerivationPath() helper function - Update derivationPaths.ts to support activity-based discovery ## Benefits ✅ Discovers ALL wallets with activity (not just first 20) ✅ BIP-44 standard compliant gap limit algorithm ✅ Efficient - stops after 20 consecutive empty addresses ✅ Performance optimized with batched parallel RPC calls ✅ Works for both Solana and Ethereum chains ✅ Comprehensive documentation included ## Usage When importing a seed phrase, the wallet will now: 1. Check addresses sequentially starting from index 0 2. Detect activity (balance or transactions) 3. Continue until finding 20 consecutive empty addresses 4. Return only wallets that have been used See ACTIVITY_BASED_WALLET_DISCOVERY.md for detailed documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements BIP-44 compliant activity-based wallet discovery to find ALL wallets with activity when importing from seed phrase, instead of just checking the first 20 addresses.
Changes
Core Implementation
Blockchain-Specific Activity Checkers
API Updates
Benefits
✅ Discovers ALL wallets with activity (not just first 20) ✅ BIP-44 standard compliant gap limit algorithm
✅ Efficient - stops after 20 consecutive empty addresses ✅ Performance optimized with batched parallel RPC calls ✅ Works for both Solana and Ethereum chains
✅ Comprehensive documentation included
Usage
When importing a seed phrase, the wallet will now:
See ACTIVITY_BASED_WALLET_DISCOVERY.md for detailed documentation.
🤖 Generated with Claude Code