Skip to content

Add toggle support for rn-bottom-drawer#14

Open
matinzd wants to merge 8 commits intojacklein:masterfrom
matinzd:master
Open

Add toggle support for rn-bottom-drawer#14
matinzd wants to merge 8 commits intojacklein:masterfrom
matinzd:master

Conversation

@matinzd
Copy link

@matinzd matinzd commented Apr 17, 2019

I have added toggle feature please accept my PR <3 thanks for your component
Fixes #11

@Dezainer
Copy link

Dezainer commented Jun 7, 2019

This looks really good, can we accept it ? Would love to use it

@matinzd
Copy link
Author

matinzd commented Jun 7, 2019

This looks really good, can we accept it ? Would love to use it

Why not?!

@ansarikhurshid786
Copy link

@Dezainer yes you should accept. Myself and other people waiting for it.

@matinzd
Copy link
Author

matinzd commented Jun 11, 2019

@Dezainer yes you should accept. Myself and other people waiting for it.

https://github.com/matinzd/rn-bottom-sheet

@ansarikhurshid786
Copy link

@matinzd https://github.com/matinzd/rn-bottom-drawer is also same right ?

@matinzd
Copy link
Author

matinzd commented Jun 11, 2019

@matinzd https://github.com/matinzd/rn-bottom-drawer is also same right ?

Somehow, but use new repository that I have mentioned above.

@ansarikhurshid786
Copy link

@matinzd thanks it is working fine

@matinzd
Copy link
Author

matinzd commented Jun 11, 2019

@matinzd thanks it is working fine

Please provide star if you liked!

@juliacodes
Copy link

@jacklein Can this please be accepted and merged? I've been waiting for this solution for some time now.

@mqtik
Copy link

mqtik commented Nov 21, 2019

It seems that no one is maintaining this library

@matinzd
Copy link
Author

matinzd commented Nov 21, 2019

Use my lib please @mqtik

@jacklein
Copy link
Owner

I never saw this!!! I'm so confused how I didn't get any notifications.

@jacklein
Copy link
Owner

Is it good to go?

@matinzd
Copy link
Author

matinzd commented Nov 21, 2019

Hi jacklein !!!! Where were you?!?!

@jacklein
Copy link
Owner

Hi jacklein !!!! Where were you?!?!

hahaha well i got a job and I haven't had much time to maintain side projects :--(

@ansarikhurshid786
Copy link

@jacklein accept this PR.

});
}

componentWillReceiveProps(nextProps) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting a warning because this is no longer recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

toggle the drawer state

7 participants