Replace dialog boxes with in-app notifications for missing screenshots#41
Merged
bhaumikmaan merged 1 commit intoj4wg:mainfrom Apr 8, 2025
Merged
Conversation
bhaumikmaan
reviewed
Apr 8, 2025
Collaborator
bhaumikmaan
left a comment
bhaumikmaan
left a comment
There was a problem hiding this comment.
Hey!
Not sure if you noticed but it is already done and handled in this PR here.
@Ornithopter-pilot can be considered to merge if #35 isn't taken forward
Thanks for the contribution.
Merged
Collaborator
Author
|
we are by default getting the notification, there is no need to bypass anything. |
bhaumikmaan
added
duplicate
Collaborator
Author
|
Removed it from #36 |
bhaumikmaan
approved these changes
Apr 8, 2025
Collaborator
bhaumikmaan
left a comment
bhaumikmaan
left a comment
There was a problem hiding this comment.
LGTM.
Moving ahead with this PR as the other one is not moving forward
Ornithopter-pilot
approved these changes
Apr 8, 2025
Collaborator
Ornithopter-pilot
left a comment
Ornithopter-pilot
left a comment
There was a problem hiding this comment.
LGTM! Good UX improvement .. Makes the app feel less disruptive while still providing the necessary user feedback. The implementation is clean and preserves all error handling paths.
Collaborator
|
@bhaumikmaan , thanks for the PR contributions ❤️ . LGTM ,you can merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #38
This PR replaces the dialog boxes with in-app notifications when users try to search without taking screenshots first. This improves the user experience by making the notifications less intrusive and allowing users to continue working without having to dismiss dialogs.