-
Notifications
You must be signed in to change notification settings - Fork 36
Add current python versions to testing #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
photodude
wants to merge
34
commits into
j4321:master
Choose a base branch
from
photodude:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add current python versions to testing last tested was 3.8 now current is 3.11
image: Visual Studio 2022 or 2019 is needed for python 3.10 and 3.11 see https://www.appveyor.com/docs/windows-images-software/#python
force update PIP to attempt pillow wheel build fix for python 3.8 and newer.
missing end quote from line 14 prevented last change from building due to syntax error
Should address the following error in python 3.8+ ```cmd The headers or library files could not be found for zlib, a required dependency when compiling Pillow from source. note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for pillow Failed to build pillow ERROR: Could not build wheels for pillow, which is required to install pyproject.toml-based projects ```
DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429). DEPRECATION: Python 3.5 reached the end of its life on September 13th, 2020. Please upgrade your Python as Python 3.5 is no longer maintained. zlib is not a python pip module attempt fixing pip issues by also upgrading setuptools and wheel
Try installing Pillow separately as it's failing to see zlib
not finding a way to install zlib on appveyor trying `--disable-zlib`
`no such option: --disable-zlib` Syntax for this option must be different
Appveyor is using a windows build environment. In a Windows environment, you can use Chocolatey to install the required libraries.
- "%PYTHON%\\python.exe -c "print(babel.__version__)"" caused a parsing error Error parsing appveyor.yml: (Line: 16, Col: 31, Idx: 500) - (Line: 16, Col: 57, Idx: 526): While parsing a block collection, did not find expected '-' indicator.
zlib is not available under choco try babel version printing again
the double quotes within double quotes, was causing a parsing error.
babel version is revealed in the pip installs
just use standard installs as upgrade of pip libraries did not solve errors
see if printing the value of self._textvariable.get() will reveal the source of the babel error
appveyor does not output values from print, try sys.stdout.write()
external libraries should not be part of code coverage and tests.
like print() sys.stdout.write(self._textvariable.get()) did not work to display information in the appveyor console
add tkinter to ignore list
Pillow 9.5.0 is the last Pillow version where they released 32-bit wheels. The solution to "Failed to build pillow" from missing zlib is to pin to old Pillow 9.5.0 or to use 64bit python. Opting for 64bit python. This should fix the wheel build errors but won't fix the issues with the Babel parse error
make a few lines single lines to see if that changes anything in the unit test errors
implement nose-exclude to correct coverage report by excluding directories that are not part of the source code https://pypi.org/project/nose-exclude/
possibly needed \projects\ before the exclude directories
nose exclude is still not excluding directories
adjust escape characters
change slash from / to \
still hunting for the right syntax for the directory to exclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add current python versions to testing
last tested was 3.8 now current is 3.11