Skip to content

Conversation

@photodude
Copy link

@photodude photodude commented Oct 4, 2023

Fixes issue #98 and #99
display problem occurs for any year where January 1 is a Sunday and firstweekday is set to "sunday". fixes code by checking if the current month is January and if January 1 of the current year falls on a Sunday. If so, it sets w to the week number returned by strftime instead of isocalendar and sets wn to zero. That fixes the January problem for years where January 1 is on a Sunday and the firstweekday = 'sunday' without messing up any other months. Code fix as proposed by @jemiele1 in #99

NOTE: automatic code checks are not working and are failing in all current PR's, something is wrong with the code check environments unrelated to this and the other PRs.
Test failures are due to ERROR: test_calendar_textvariable (tests.test_calendar.TestCalendar) from tkcalendar\tests\test_calendar.py", line 228, in test_calendar_textvariable year=2015, month=1, day=3, textvariable=var)
which causes

babel\dates.py", line 1201, in parse_date raise ParseError("No numbers were found in input")
babel.dates.ParseError: No numbers were found in input

This build error only occurs in the python 3.6 and 3.7 builds and should be addressed outside of this PR

Fixes  issue j4321#98 and j4321#99
display problem occurs for any year where January 1 is a Sunday and firstweekday is set to "sunday".  fixes code by checking if the current month is January and if January 1 of the current year falls on a Sunday. If so, it sets w to the week number returned by strftime instead of isocalendar and sets wn to zero. That fixes the January problem for years where January 1 is on a Sunday and the firstweekday = 'sunday' without messing up any other months. Code fix as proposed by @jemiele1 in j4321#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant