-
-
Notifications
You must be signed in to change notification settings - Fork 123
Allow GIT_CONFIG_PARAMETERS for private repository authentication
#1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
==========================================
- Coverage 91.05% 90.87% -0.19%
==========================================
Files 87 87
Lines 18367 18529 +162
==========================================
+ Hits 16724 16838 +114
- Misses 1643 1691 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (22.8 MiB → 22.8 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
7f9684c to
548a595
Compare
Allow GIT_CONFIG_PARAMETERS to pass through to git commands, enabling users to configure credentials for private repositories via environment variables. Closes j178#1377
cf06b5b to
77d9340
Compare
Document how to authenticate with private hook repositories: - Credential helpers (gh CLI, osxkeychain, Git Credential Manager) - SSH URLs with agent - URL rewriting with tokens for CI
b6ff984 to
17f903b
Compare
|
@j178 Most of the code changes in this PR are from adding hint messages in feat: show auth hints for private repo errors, but the main functional change is in feat(git): add GIT_CONFIG_PARAMETERS to env var allowlist. Let me know if you disagree with the former and I can drop that commit; it got a bit messy as I tried to add the error messages to both |
GIT_CONFIG_PARAMETERS for private repository authentication
|
Thanks! The FAQ part looks great. About that last commit (17f903b), it feels a bit more complicated than I expected, so I might hold off on including it for now. |
17f903b to
5b9003a
Compare
|
Dropped the last commit. |
Changes:
GIT_CONFIG_PARAMETERSto the environment variable allowlist, enabling URL rewriting for private repository authentication in CI environments.Closes #1377