-
-
Notifications
You must be signed in to change notification settings - Fork 123
fix(windows): keep VT enabled during progress #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1465 +/- ##
==========================================
+ Coverage 90.99% 91.06% +0.06%
==========================================
Files 86 87 +1
Lines 18182 18384 +202
==========================================
+ Hits 16545 16741 +196
- Misses 1637 1643 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.00% (22.8 MiB → 22.8 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
2943c82 to
f7e1e45
Compare
Some Windows hook installers (uv, pip, npm, cargo) disable ENABLE_VIRTUAL_TERMINAL_PROCESSING on exit, which causes indicatif's progress output to render as raw ANSI escape sequences. Re-enable VT mode after subprocess output() and status() calls to restore console state before prek resumes its own output.
f7e1e45 to
762d114
Compare
|
Keeping in draft until @chrisoro or someone with a Windows machine can confirm this actually fixes the issue lolol |
|
Any chance to build arm64 version of it? I won't have access to my amd64 win machine until end of next week. I do have windows on arm as a vm on my mac |
|
Just did a dummy change to @chrisoro The link for the ARM Windows standalone binary specifically is https://github.com/j178/prek/actions/runs/21322541711/artifacts/5245733919. Looks like it's a zip file in another zip file lol, but the inner zip has a Let me know how it goes! |
Some Windows hook installers (uv, pip, npm, cargo) disable
ENABLE_VIRTUAL_TERMINAL_PROCESSINGon exit, which causes indicatif's progress output to render as raw ANSI escape sequences duringprek install.Re-enables VT mode after subprocess
output()andstatus()calls to restore console state before prek resumes its own output.Fixes #1237