Support prek.toml

[j178]

Closes #593

[codecov]

Codecov Report

❌ Patch coverage is 46.87500% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.70%. Comparing base (c5f1270) to head (9250c04).

Files with missing lines	Patch %	Lines
crates/prek/src/workspace.rs	60.71%	22 Missing ⚠️
crates/prek/src/config.rs	33.33%	18 Missing ⚠️
crates/prek/src/cli/auto_update.rs	0.00%	3 Missing ⚠️
crates/prek/src/cli/try_repo.rs	0.00%	3 Missing ⚠️
crates/prek/src/hook.rs	40.00%	3 Missing ⚠️
crates/prek/src/cli/hook_impl.rs	0.00%	1 Missing ⚠️
crates/prek/src/cli/install.rs	0.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c5f1270) and HEAD (9250c04). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (c5f1270)	HEAD (9250c04)
	2	1

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #1271       +/-   ##
===========================================
- Coverage   90.00%   23.70%   -66.30%     
===========================================
  Files          80       80               
  Lines       15881    15850       -31     
===========================================
- Hits        14293     3757    -10536     
- Misses       1588    12093    +10505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

📦 Cargo Bloat Comparison

Binary size change: +0.60% (16.7 MiB → 16.8 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.7%   1.4% 115.4KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.6%   1.3% 107.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.7%  54.7KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.7%  52.8KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.5%  39.6KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.2KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  39.2KiB           prek prek::run::{{closure}}
 0.2%   0.5%  38.7KiB          prek? <prek::config::_::<impl serde_core::de::Deserialize for prek::config::Config>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map
 0.2%   0.5%  37.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.5%  37.3KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
 0.2%   0.5%  36.9KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  30.8KiB           std? <core::marker::PhantomData<T> as serde_core::de::DeserializeSeed>::deserialize
 0.2%   0.4%  30.7KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  29.8KiB           prek prek::languages::rust::installer::RustInstaller::install::{{closure}}
 0.2%   0.4%  28.4KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.3%  27.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.3%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  27.3KiB           prek prek::cli::run::run::run_hooks::{{closure}}
 0.2%   0.3%  26.1KiB           prek prek::cli::auto_update::update_repo::{{closure}}
 0.1%   0.3%  25.3KiB           prek prek::main
41.3%  88.4%   6.9MiB                And 10694 smaller methods. Use -n N to show more.
46.7% 100.0%   7.8MiB                .text section size, the file size is 16.8MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.7%   1.5% 115.5KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}::{{closure}}
 0.6%   1.3% 107.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.3%   0.7%  54.7KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.7%  52.8KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.5%  39.8KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.2KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  39.2KiB           prek prek::run::{{closure}}
 0.2%   0.5%  37.3KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
 0.2%   0.5%  36.9KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.5%  36.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.8KiB           std? <core::marker::PhantomData<T> as serde_core::de::DeserializeSeed>::deserialize
 0.2%   0.4%  30.7KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  29.8KiB           prek prek::languages::rust::installer::RustInstaller::install::{{closure}}
 0.2%   0.4%  28.4KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  27.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.3%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  27.3KiB           prek prek::cli::run::run::run_hooks::{{closure}}
 0.2%   0.3%  26.2KiB           prek prek::cli::auto_update::update_repo::{{closure}}
 0.1%   0.3%  25.3KiB           prek prek::main
 0.1%   0.3%  24.7KiB           prek prek::hook::HookBuilder::build::{{closure}}
41.2%  88.5%   6.9MiB                And 10639 smaller methods. Use -n N to show more.
46.5% 100.0%   7.8MiB                .text section size, the file size is 16.7MiB

[pygarap]

@j178 if prek.toml is the equivalent of .pre-commit-config.yaml, why not rename it to prek-config.toml and also add support for prek-hooks.toml as the equivalent of .pre-commit-hooks.yaml?

[ulgens]

if prek.toml is the equivalent of .pre-commit-config.yaml, why not rename it to prek-config.toml and also add support for prek-hooks.toml as the equivalent of .pre-commit-hooks.yaml?

Similar question here. Will this be an alternative to .pre-commit-config.yaml file or is it to keep prek settings?

[OJFord]

@ulgens The description is 'Closes #593', it's the former. (Also as you can see clearly from:
https://github.com/j178/prek/pull/1271/changes#diff-ff219642554f55d0b52b321bd22873805b5075725d97a9caabd22f3e53f0c63bR132)

Regarding the name, my 2p would be that prek.toml makes more sense if you forget the history. It's a toml file, obviously it's some kind of config, it doesn't need to be called that the same way I don't have Cargo-config.toml or pyproject-config.toml. (In fairness, it does seem more popular in the JS world to have *.config.js, but I suppose back to my first point - unlike toml, js isn't readily apparent as a config file.)

[ulgens]

@OJFord Oh, thank you. Checking it again now, it seems clear but I was confused at the time.

[pygarap]

But what about prek-hooks.toml?