Open
Conversation
Owner
|
Thank you, tenomoto, for your comments. I have just committed some changes for version 2.2.3. Please check if your issues are still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calls to
utScan()fromcompare_units()insrc/gasdf.ccause errors due to an incorrect truncation.I experienced errors with udunits2 and segmentation faults with udunits.
For example, the length of "
hours since" is 11 and that oftemp_str(starting from "since" with a leading white space is 6.trunc_unitsshould be terminated at the white space between "hours" and "since", which is 5.Therefore adding 1 add an extra white space to
trunc_units.In addition, I edited
configureto remove version string from png and respectCPPFLAGSandLDFLAGSin finding wgrib2.