Open
Conversation
…onditionally complete partial order, then `X` is extremally disconnected
JonBannon
reviewed
Mar 20, 2026
LeanOA/Mathlib/Analysis/CStarAlgebra/ContinuousFunctionalCalculus/Range.lean
Show resolved
Hide resolved
JonBannon
reviewed
Mar 20, 2026
Collaborator
JonBannon
left a comment
JonBannon
left a comment
There was a problem hiding this comment.
Just a bunch of comments, meant to help me understand design-related issues.
|
|
||
| open scoped CStarAlgebra | ||
|
|
||
| section Bar |
Collaborator
There was a problem hiding this comment.
Suggested change
| section Bar | |
| section Range |
|
|
||
| end Unital | ||
|
|
||
| end Bar |
Collaborator
There was a problem hiding this comment.
Suggested change
| end Bar | |
| end Range |
| open WeakDual ContinuousMap | ||
| open scoped ComplexOrder | ||
|
|
||
| namespace ContinuousMap |
Collaborator
There was a problem hiding this comment.
move to Mathlib/Analysis/RCLike/ContinuousMap
| variable {α : Type*} (𝕜 : Type*) [TopologicalSpace α] [RCLike 𝕜] | ||
|
|
||
| /-- `ContinuousMap.realToRCLike` as an order embedding. -/ | ||
| def realToRCLikeOrderEmbedding : |
Collaborator
There was a problem hiding this comment.
Suggested change
| def realToRCLikeOrderEmbedding : | |
| variable (α) in | |
| def realToRCLikeOrderEmbedding : |
|
|
||
| end ContinuousMap | ||
|
|
||
| section Unitary |
Collaborator
There was a problem hiding this comment.
Mathlib/Algebra/Star/Unitary
| section StarMemClass | ||
|
|
||
| @[simp] | ||
| lemma Subtype.isSelfAdjoint_iff {S R : Type*} [Star R] [SetLike S R] [StarMemClass S R] |
Collaborator
There was a problem hiding this comment.
I think SetLike is more appropriate than subtype here
Suggested change
| lemma Subtype.isSelfAdjoint_iff {S R : Type*} [Star R] [SetLike S R] [StarMemClass S R] | |
| lemma SetLike.isSelfAdjoint_iff {S R : Type*} [Star R] [SetLike S R] [StarMemClass S R] |
|
|
||
| end Unitary | ||
|
|
||
| section CommuteSpan |
Collaborator
There was a problem hiding this comment.
move to somewhere in Mathlib/Algebra probably?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.