Skip to content

Conversation

@jKatt
Copy link
Contributor

@jKatt jKatt commented Dec 18, 2025

This PR removes MultiJson from the JSON middleware.
With the adjustments made to JSON a while ago, there is no need to use another gem for JSON parsing.

Copy link
Contributor

@johannesluedke johannesluedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ears is also used outside of our org. If someone relied on multi json and f.e. some custom oj config -- maybe we should make this a major version change

Copy link
Contributor

@johannesluedke johannesluedke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to release it, don't forget to adjust version.rb and CHANGELOG

@jKatt
Copy link
Contributor Author

jKatt commented Dec 18, 2025

ears is also used outside of our org. If someone relied on multi json and f.e. some custom oj config -- maybe we should make this a major version change

I thought about making it a minor change, as we are still on the 0 major version.
Bumping it to major 1 would mean we are finally on a production-ready major version 🤔

@johannesluedke
Copy link
Contributor

ears is also used outside of our org. If someone relied on multi json and f.e. some custom oj config -- maybe we should make this a major version change

I thought about making it a minor change, as we are still on the 0 major version. Bumping it to major 1 would mean we are finally on a production-ready major version 🤔

ah, then minor is fine 👍

@jKatt jKatt merged commit b7ffa1f into main Dec 18, 2025
7 checks passed
@jKatt jKatt deleted the remove-multi-json branch December 18, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants