Conversation
added 2 commits
February 26, 2023 02:43
ivapbox
commented
Feb 27, 2023
| // неясно для чего подключается клиент, закомментировал, но это явно некорректный код | ||
| // $bill->setBillClient(new BillMicroserviceClient()); | ||
| // но если нужно поменять какое-то поле (к примеру is_paid) - то в конце не забываем добавить | ||
| // $this->billRepository->save($bill); |
Owner
Author
There was a problem hiding this comment.
Уточню что save только INSERT'ит, а нужен UPDATE, т.е. или перепилить метод, или сделать новый
ivapbox
commented
Feb 27, 2023
| ->setSum($billData['sum']) | ||
| ->setType($billData['type']) | ||
| ->setItems($items) | ||
| // ->setIsPaid($billData['is_paid']) |
Owner
Author
There was a problem hiding this comment.
Закомментировано, т.к. есть вопросы по этому полю
ivapbox
commented
Feb 27, 2023
|
|
||
| class ItemRepository implements ItemRepositoryInterface | ||
| { | ||
| protected $pdo; |
Owner
Author
There was a problem hiding this comment.
Забыл поправить на private
ivapbox
commented
Feb 27, 2023
| class BillRepository | ||
| class BillRepository implements BillRepositoryInterface | ||
| { | ||
| protected $pdo; |
Owner
Author
There was a problem hiding this comment.
Забыл поправить на private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.