Skip to content

Comments

Feat/crop#196

Open
revengemiroz wants to merge 20 commits intomainfrom
feat/crop
Open

Feat/crop#196
revengemiroz wants to merge 20 commits intomainfrom
feat/crop

Conversation

@revengemiroz
Copy link
Collaborator

@revengemiroz revengemiroz commented Jul 3, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Showcase

Please attach a picture or a video showing what this change does.

@revengemiroz revengemiroz requested a review from ivanms1 July 3, 2023 11:19
@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-shelf-admin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:00pm
project-shelf-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:00pm

<Modal
open={showProfilePic}
onClose={() => setShowProfilePic(false)}
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-10 overflow-hidden'

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not done

<Modal
open={showCoverPic}
onClose={() => setShowCoverPic(false)}
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-10 overflow-hidden'

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not done

Copy link
Collaborator

@rohilpinto rohilpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivanms1 ivanms1 added the enhancement New feature or request label Jul 9, 2023
Copy link
Owner

@ivanms1 ivanms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just two small changes

<Modal
open={showProfilePic}
onClose={() => setShowProfilePic(false)}
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not done

<Modal
open={showCoverPic}
onClose={() => setShowCoverPic(false)}
modalClassName='bg-grey-dark flex flex-col justify-center p-12 w-[40vw] overflow-hidden'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also not done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants