Conversation
|
only one test? |
smarks
reviewed
Oct 16, 2018
| <output-test url="file://$MODULE_DIR$/target/test-classes" /> | ||
| <content url="file://$MODULE_DIR$"> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/java" isTestSource="false" /> | ||
| <sourceFolder url="file://$MODULE_DIR$/src/main/resources" type="java-resource" /> |
There was a problem hiding this comment.
also, jar files should not be checked into the source tree.
|
Generally nice work here. Need more tests though. |
|
Great to see the circle ci build working. However, 11 tests is a bit low. Try to add some more. |
|
72 files are too many changes. |
smarks
reviewed
Oct 16, 2018
|
|
||
| import java.util.List; | ||
|
|
||
| /** |
smarks
reviewed
Oct 16, 2018
| import java.util.List; | ||
|
|
||
| /** | ||
| * |
smarks
reviewed
Oct 16, 2018
| public class DatabaseActivitiesService implements ActivitiesService { | ||
|
|
||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that I finished everything besides the JUnit tests.