Conversation
|
Please add circle ci part and I'll grade. |
smarks
reviewed
Oct 5, 2018
| package StockServices; | ||
|
|
||
| import java.util.Calendar; | ||
|
|
smarks
reviewed
Oct 5, 2018
| this.week = week; | ||
| } | ||
|
|
||
| public void weekChosen() { |
There was a problem hiding this comment.
not sure what this code is about?
you don't need this. Interval should be an enum the describes a period of time. e.g. a minute, hour, day etc.
smarks
reviewed
Oct 5, 2018
| StockServiceFactory stockServiceFactory = new StockServiceFactory(); | ||
| basicStockService.getStockQuote(Symbol, From, Until, INTERVAL); | ||
| return stockServiceFactory; | ||
| /*returs stock service*/ |
There was a problem hiding this comment.
don't need comments like this. what the code is doing is obvious
smarks
reviewed
Oct 5, 2018
| @Test | ||
| void getQuote4() { | ||
| } | ||
|
|
smarks
suggested changes
Oct 5, 2018
smarks
left a comment
smarks
left a comment
There was a problem hiding this comment.
Please address comments and I'll re-grade.
smarks
approved these changes
Oct 14, 2018
|
have not see the fixes for this code yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started re writing my program, I still haven't reached the testing phase yet.