Open
Conversation
smarks
reviewed
Sep 30, 2018
| @@ -0,0 +1,34 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
smarks
reviewed
Sep 30, 2018
|
|
||
| public class BasicStockService implements StockService { | ||
| @Override | ||
| public StockQuote getQuote(String symbol) { |
smarks
reviewed
Sep 30, 2018
| public class StockQuoteApplication { | ||
| public static void main(String[] args) throws ParseException { | ||
| StockServiceFactory SSF = new StockServiceFactory(); | ||
| Scanner input = new Scanner(System.in); |
There was a problem hiding this comment.
use whole word variables but the stockservice should only have static methods and a private constructor so that client code can't create instances of them.
smarks
reviewed
Sep 30, 2018
| System.out.println("View stocks starting at what date? "); | ||
| startDate = input.nextLine(); | ||
| Date fromDate = sdf.parse(startDate); | ||
| Calendar startCalendar = Calendar.getInstance(); |
smarks
reviewed
Sep 30, 2018
| import java.util.List; | ||
|
|
||
| public class StockServiceFactory extends BasicStockService{ | ||
| public StockServiceFactory getStockService(String symbol, Calendar fromDate, Calendar toDate){ |
There was a problem hiding this comment.
this method should return a StockService not a StockServiceFactory
|
Hi, No circle ci tests... Let's definitely find a time to chat. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry fro the lateness of this homework submission