Skip to content

Did my best#1

Open
ivanmaker wants to merge 2 commits intomasterfrom
assignment_one
Open

Did my best#1
ivanmaker wants to merge 2 commits intomasterfrom
assignment_one

Conversation

@ivanmaker
Copy link
Owner

There was a lot of new material for me to take in in this first week, I stumbled in a lot of places but still managed to generate a shadow of the correct output. I hope its not too incredibly far off the mark.

@smarks
Copy link

smarks commented Sep 14, 2018

Hi,
This is pretty good.
You need to include the circle ci part.
Do not include generated files such as those files under ./idea or target.
You can exclude them by using a .gitignore file. See the chat recording for me info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants