fix dirtyAttributes to look at persisted values rather than latest and remove observability from data property on store#459
Open
fix dirtyAttributes to look at persisted values rather than latest and remove observability from data property on store#459
Conversation
jondayton
commented
Feb 21, 2023
|
|
||
| todo.notes.add(note) | ||
| note.description = 'something different' | ||
| todo.notes.replace([note, note2]) |
Contributor
Author
There was a problem hiding this comment.
this takes a snapshot, which was making dirtyAttributes compare against the latest version of the model instead of the original one.
jondayton
commented
Feb 21, 2023
Comment on lines
+682
to
+684
| records: new Map(), | ||
| cache: new Map(), | ||
| meta: new Map() |
Contributor
Author
There was a problem hiding this comment.
we're not actually observing this anywhere, so it's just a performance hit. It would be cool to observe it though.
jondayton
commented
Feb 21, 2023
| return Object.keys(this.attributes).reduce((dirtyAccumulator, attr) => { | ||
| const currentValue = this.attributes[attr] | ||
| const previousValue = this.previousSnapshot.attributes[attr] | ||
| const previousValue = this.persistedOrFirstSnapshot.attributes[attr] |
jondayton
commented
Feb 21, 2023
Comment on lines
+299
to
+303
| expect(store.data).toEqual({ | ||
| todos: { cache: new Map(), meta: new Map(), records: new Map() }, | ||
| notes: { cache: new Map(), meta: new Map(), records: new Map() }, | ||
| categories: { cache: new Map(), meta: new Map(), records: new Map() }, | ||
| tags: { cache: new Map(), meta: new Map(), records: new Map() } |
Contributor
Author
There was a problem hiding this comment.
This is fora performance improvement (see below)
jackiekircher
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.