-
Notifications
You must be signed in to change notification settings - Fork 101
6212 ТудаковРА Лаб. 1 #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rodiontudakov-dev
wants to merge
4
commits into
itsecd:main
Choose a base branch
from
rodiontudakov-dev:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxwrlld
reviewed
Nov 29, 2025
mxwrlld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Общие моменты:
- Классы именуем согласно БЭМ по шаблону
имя-блока__имя-элемента_имя-модификатора. Подробнее тут и тут. Например, в 4 задании блоком может быть классmaze, элементамиcell -> maze__cell,wall-rightи т.д. будут модификаторами елементаmaze__cell, т.е.maze__cell_wall-rightилиmaze__cell_wall_right - Сделайте лабиринт более похожим на лабиринт. Сейчас он больше напоминает плитку:
mxwrlld
requested changes
Dec 8, 2025
mxwrlld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Напоминаю о необходимости внесения изменений
Author
Author
|
Здравствуйте, простите, с утра уже сделаю, а то у меня проблемы с
интернетом в общежитии, а с телефона не воспринимает wi-fi. Подойдет такой
вариант?
Пт, 19 дек. 2025 г. в 04:09, Максим Якубенко ***@***.***>:
… *mxwrlld* left a comment (itsecd/web-base#305)
<#305 (comment)>
Необходимо оформить коммит (в ветку вашего репозитория, для которой открыт
PR), а не приложить файлы к комментарию
В вашем случае PR открыт из ветки main:
image.png (view on web)
<https://github.com/user-attachments/assets/39eb5d9f-8e5c-44cc-bcb0-9571565b0d7a>
—
Reply to this email directly, view it on GitHub
<#305 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/B2WEQ4SY2G3U2OM3CGOXBJL4CM62LAVCNFSM6AAAAACNGCYPP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZSHAYTKMBXGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Да, конечно |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



No description provided.