6212 ЩукинЯВ Лаб.3 #274
Closed
6212 ЩукинЯВ Лаб.3 #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxwrlld
reviewed
Nov 24, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
Отлично!
К адаптивности в целом вопросов нет, единственное - текст элемента "Направление" не вмещается в блок при просмотре с мобильных устройств. Обработайте эту ситуацию
index.html
Outdated
| <meta charset="UTF-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <title>Резюме</title> | ||
| <link rel="stylesheet" href="style/style.css"> |
index.html
Outdated
| <header class="resume__header"> | ||
| <div class="resume__photo-section"> | ||
| <img | ||
| src="style/images.jpg" |
There was a problem hiding this comment.
Ссылка некорректная + изображения лучше размещать в папках с изображениями, вместо style
index.html
Outdated
Comment on lines
53
to
58
| <div class="skills"> | ||
| <span class="skill">C++</span> | ||
| <span class="skill">HTML</span> | ||
| <span class="skill">CSS</span> | ||
| <span class="skill">Python</span> | ||
| </div> |
There was a problem hiding this comment.
По БЭМ тут более подходящим будет вариант skills__item, как и в блоке хобби
Author
|
исправил |
|
Исправьте ссылки на CSS - файл и аватарку. Все ещё некорректны. В репозитории нет папки В остальном все хорошо, остальные замечания учтены |
mxwrlld
requested changes
Dec 19, 2025
mxwrlld
left a comment
mxwrlld
left a comment
There was a problem hiding this comment.
Напоминаю о необходимости внесения изменений!
Author
|
Сделал |
|
Ура! Зачтено! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.