Лаб. 4 6412 Чуева Мария #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
In progress
alxmcs
requested changes
Dec 25, 2025
| IList<string> arrivalCity) => | ||
| new Faker<CreateFlightDto>() | ||
| .CustomInstantiator(f => new CreateFlightDto( | ||
| FlightCode: f.Random.String2(2, "ABCDEFGHIJKLMNOPQRSTUVWXYZ") + f.Random.Number(100, 999), |
Contributor
There was a problem hiding this comment.
Для подобной генерации нужно использовать faker.Random.Char('A', 'Z'), нет необходимости каждую генерацию создавать строку с алфавитом
Comment on lines
43
to
53
| var modelId = configuration.GetSection("FlightGenerator:ModelFamilyId") | ||
| .Get<int[]>() ?? []; | ||
|
|
||
| var departureCity = configuration.GetSection("FlightGenerator:DepartureCity") | ||
| .Get<string[]>() ?? []; | ||
|
|
||
| var arrivalCity = configuration.GetSection("FlightGenerator:ArrivalCity") | ||
| .Get<string[]>() ?? []; | ||
|
|
||
| if (modelId.Length == 0 || departureCity.Length == 0 || arrivalCity.Length == 0) | ||
| return StatusCode(StatusCodes.Status500InternalServerError, "SeedModelIds is empty"); |
Contributor
There was a problem hiding this comment.
Все эти данные принадлежат генератору, а не контроллеру. Необходимо перенести их в генератор и сделать статическими, чтобы не дергать конфигурацию на каждый вызов метода
Author
|
Мне жаль, что такой разрыв по времени между поправками получился, каюсь... |
alxmcs
approved these changes
Dec 25, 2025
alxmcs
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ФИО: Чуева Мария
Номер группы: 6412
Номер лабораторной: 4
Номер варианта: 53
Краткое описание предметной области: Авиакомпания
Краткое описание добавленных фич: С помощью брокера сообщений Apache Kafka реализован Kafka Producer с генератором случайных данных через Bogus и добавлен Kafka Consumer, который подписывается на топик и сохраняет полученные данные в базу данных.