Лаб. 3 6413 Зюзин Егор #228

derasoft004 · 2025-12-21T12:48:49Z

ФИО: Зюзин Егор
Номер группы: 6413
Номер лабораторной: 3
Номер варианта: 67
Краткое описание предметной области: Поликлиника
Краткое описание добавленных фич: «ORM» - Реализовал объектно-реляционную модель. Подключился к базе данных PostgreSQL, проект полностью освободился от inmemory инфраструктуры.

This reverts commit 2a917f8.

…moved to subjects folder)

…nd add some comments

…data (for good results)

… to some doctors

…aSeed file)

… make class DataSeed static class

commit 17: add PolyclinicTests.yml - action for my tests

…ary and remove some from Tests.csproj

… controller-level now can get response about invalid api request

…ger, i added a doctor 'name')

…nd get it in swagger. lab3

DmitryKrakhmalev

Есть замечания. Перед тем как направлять свою работу на проверку, лучше проанализировать солюшен на наличие ошибок.
Не вижу Aspire проекта;
Нужен cleanup и переименовка некоторых папок;
У вас тесты падают с ошибкой.

DmitryKrakhmalev · 2025-12-22T15:59:38Z

Polyclinic/Polyclinic.Tests/Application/AnalyticsServiceTests.cs

+{
+    private readonly Mock<IRepository<Appointment, int>> _mockAppointmentRepository;
+    private readonly Mock<IRepository<Patient, int>> _mockPatientRepository;
+    private readonly IAnalyticsService _analyticsService;


Если вы в конструкторе создаете AnalyticsService то и тут тип лучше прописать AnalyticsService вместо интерфейса.

DmitryKrakhmalev · 2025-12-22T16:00:00Z

Polyclinic/Polyclinic.Tests/Application/AnalyticsServiceTests.cs

+public class AnalyticsServiceTests
+{
+    private readonly Mock<IRepository<Appointment, int>> _mockAppointmentRepository;
+    private readonly Mock<IRepository<Patient, int>> _mockPatientRepository;


Не используется, можно убрать.

DmitryKrakhmalev · 2025-12-22T16:14:26Z

Polyclinic/Polyclinic.Tests/API/AnalyticsControllerTests.cs

+using Polyclinic.Contracts.Dto;
+using Xunit;
+
+namespace Polyclinic.Tests.API;


Папку API переименовать в PascalCase. Не забыть про неймспейсы.

DmitryKrakhmalev · 2025-12-22T16:14:55Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Configurations/AppointmentConfiguration.cs

+using Microsoft.EntityFrameworkCore.Metadata.Builders;
+using Polyclinic.Domain.Subjects;
+
+namespace Polyclinic.Infrastructure.PostgreSQL.Configurations;


Папку PostgreSQL переименовать в PascalCase. Не забыть про неймспейсы.

DmitryKrakhmalev · 2025-12-22T16:15:35Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Migrations/20251221122424_InitialCreate.cs

@@ -0,0 +1,185 @@
+using System;


Добавить первой строкой // <auto-generated />

DmitryKrakhmalev · 2025-12-22T16:22:28Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Repository/PostgresPatientRepository.cs

+    /// </summary>
+    public List<Patient> ReadAll()
+    {
+        return context.Patients.ToList();


Упростить

DmitryKrakhmalev · 2025-12-22T16:22:42Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Repository/PostgresSpecializationRepository.cs

+
+    public List<Specialization> ReadAll()
+    {
+        return context.Specializations.ToList();


DmitryKrakhmalev · 2025-12-22T16:23:11Z

Polyclinic/Polyclinic.Tests/API/AnalyticsControllerTests.cs

+    [Fact]
+    public void GetPatientsByDoctor_NoPatients_ReturnsNotFound()
+    {
+        _mockAnalyticsService.Setup(service => service.GetPatientsByDoctor(999)).Returns(new List<PatientDto>());


Suggested change

_mockAnalyticsService.Setup(service => service.GetPatientsByDoctor(999)).Returns(new List<PatientDto>());

_mockAnalyticsService.Setup(service => service.GetPatientsByDoctor(999)).Returns([]);

DmitryKrakhmalev · 2025-12-22T16:23:48Z

Polyclinic/Polyclinic.API.Host/Controllers/AnalyticsController.cs

+
+            var patients = analyticsService.GetPatientsByDoctor(id);
+
+            if (patients == null || !patients.Any())


Suggested change

if (patients == null || !patients.Any())

if (patients == null || patients.Count == 0)

DmitryKrakhmalev · 2025-12-22T16:24:18Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/PolyclinicDbContext.cs

+
+public class PolyclinicDbContext : DbContext
+{
+    public PolyclinicDbContext(DbContextOptions<PolyclinicDbContext> options)


primary constructor

…c. rename to pascalcase namespace.

…some tests

DmitryKrakhmalev

Обратите внимание на замечания выше. Я не увидел чтобы они были устранены. Также добавил новые замечания.
Вам необходимо устранить все замечание, а главное:

Использовать Aspire;
При работе с базой данных необходимо использовать асинхронные методы. Переделайте репозитории.

Polyclinic/Polyclinic.API.Host/Controllers/AnalyticsController.cs

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Repository/PostgresPatientRepository.cs

DmitryKrakhmalev · 2025-12-24T17:46:31Z

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Repository/PostgresPatientRepository.cs

+    /// </summary>
+    public int Create(Patient entity)
+    {
+        context.Patients.Add(entity);


Работать нужно с асинхронными методами. Переделать все методы репозиториев на асинхронные

Polyclinic/Polyclinic.Infrastructure.PostgreSQL/Repository/PostgresSpecializationRepository.cs

DmitryKrakhmalev · 2025-12-24T17:48:06Z

Polyclinic/Polyclinic.Tests/Application/PatientServiceTests.cs

+    private readonly Mock<IRepository<Patient, int>> _mockPatientRepository;
+    private readonly Mock<IRepository<Appointment, int>> _mockAppointmentRepository;
+    private readonly PolyclinicDbContext _dbContext;
+    private readonly IPatientService _patientService;


Замечание не устранено.

DmitryKrakhmalev · 2025-12-26T10:10:43Z

Я не вижу запроса не Review. 4 PR буду принимать только когда по этому будут устранены все замечания.

DmitryKrakhmalev

Работу засчитываю. Так как некоторые замечания не были устранены (главное из них использование асинхронных методов), оценка -1 балл.

derasoft004 and others added 30 commits October 28, 2025 10:45

commit 1: add class Patient

2a917f8

Revert "commit 1: add class Patient"

f1b970e

This reverts commit 2a917f8.

commit 1: add Patient class

70dc48b

commit 1.1: try to fix

fd19741

commit 2: add enums and patient's fields

fc6ddbf

commit 3: added appointment and doctor classes (they and patient was …

007d80e

…moved to subjects folder)

commit 4: fill dataseed and add id for each class

2250b98

commit 5: add test with doctors expirience

b0d997e

commit 6: remake test structure and add TestFixture for unit tests

f3731da

commit 7: add one more test with patients by appointments to doctor a…

d8ca948

…nd add some comments

commit 8: add RepeatAppointmentsCountLastMonth test and correct some …

7588c16

…data (for good results)

commit 9: add test with patient who age is more 30 and they appointed…

bcee2f1

… to some doctors

commit 10: add test with appointments in some room at chosen month

44cb78d

commit 11: restructure project

334d649

to commit 11

ea0b447

commit 12: add required or nullable to classes' fields

74cf48f

commit 13: removed method set from fields aren't using setter (in Dat…

d34084c

…aSeed file)

commit 14: some fix tasts' data, fix cspoj Polyclinic.Domain file and…

df5c1dd

… make class DataSeed static class

commit 15: add xml comments

b6286f0

to commit 14

51bcbae

commit 16: update README.md

f7e6d12

commit 16: update README.md

ab36856

Create PolyclinicTests.yml

b7b0674

commit 17: add PolyclinicTests.yml - action for my tests

Update PolyclinicTests.yml - change path for dependencies

d49b789

Create .NET Tests lab1.yml

918b338

Update PolyclinicTests.yml

ffaaf58

Delete .github/workflows/PolyclinicTests.yml

c42ac06

Merge branch 'lab1'

89fa27d

Update .NET Tests.yml

e6cb488

commit 17 (1th commit after merge): some fix test according to AAA model

3ac3cb9

derasoft004 added 14 commits December 12, 2025 15:12

commit 34: change the constructor for the AnalyticsService: made primary

828b332

to commit 34: change the constructor for the all services : made prim…

5a9451d

…ary and remove some from Tests.csproj

commit 35: some little changes

2b9c532

commit 36: added error handlers for creating and updating subjects on…

441b88d

… controller-level now can get response about invalid api request

to commit 36: fix constructor as well

abeab8b

to commit 36: little changes (no logic)

ceea611

commit 37: some fixes for better reading and logic

7f181e9

commit 38: change using swagger always (now can add entities wia swag…

70df9f3

…ger, i added a doctor 'name')

commit 39: add postgre context

1d6ce76

commit 40: configure subjects

7c3bcf1

commit 41: add repositories

3f566aa

comnmit 42: add seeder and extensions

036f501

commit 43: a lot of changes and updates to create DB, do migrations a…

bb866bd

…nd get it in swagger. lab3

commit 44: fix test and prepare lab3

e74f19e

github-actions bot added In progress Код в процессе проверки Lab 3 Лабораторная №3. ORM labels Dec 21, 2025

github-actions bot requested a review from DmitryKrakhmalev December 21, 2025 12:48

commit 45: replaced an integration test and made inmemory db for tests.

ddaedde

DmitryKrakhmalev requested changes Dec 22, 2025

View reviewed changes

derasoft004 and others added 3 commits December 24, 2025 19:12

commit 45: little changes in names and methods, constructors and logi…

6dd507f

…c. rename to pascalcase namespace.

Merge branch 'main' into lab3

c9b8429

commit 46: fix tests from using postgre config on git to inmemory on …

49ba486

…some tests

derasoft004 requested a review from DmitryKrakhmalev December 24, 2025 16:12

DmitryKrakhmalev requested changes Dec 24, 2025

View reviewed changes

commit 47: some fixes

40010ec

DmitryKrakhmalev approved these changes Dec 26, 2025

View reviewed changes

DmitryKrakhmalev added Approved Лабораторная зачтена and removed In progress Код в процессе проверки labels Dec 26, 2025

DmitryKrakhmalev closed this Dec 26, 2025

	_mockAnalyticsService.Setup(service => service.GetPatientsByDoctor(999)).Returns(new List<PatientDto>());
	_mockAnalyticsService.Setup(service => service.GetPatientsByDoctor(999)).Returns([]);


		var patients = analyticsService.GetPatientsByDoctor(id);

		if (patients == null \|\| !patients.Any())

	if (patients == null \|\| !patients.Any())
	if (patients == null \|\| patients.Count == 0)

Лаб. 3 6413 Зюзин Егор #228

Лаб. 3 6413 Зюзин Егор #228

Uh oh!

Conversation

derasoft004 commented Dec 21, 2025

Uh oh!

DmitryKrakhmalev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmitryKrakhmalev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DmitryKrakhmalev commented Dec 26, 2025

Uh oh!

DmitryKrakhmalev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants