add perfect-scrollbar as dependency#96
Open
mischkl wants to merge 3 commits intoitsdrewmiller:masterfrom
Open
Conversation
Collaborator
|
Thank you. This looks good. Should the Code page docs (README.md) be updated to match? NPM could be added as an install option. |
Author
|
Good idea. I've now updated the README in my pull request to include information about installing with NPM and using with Webpack. |
|
Are there any ideas about when is this going to be merged? |
Collaborator
|
Has anyone tested it? It's not difficult to clone the repo and have a look at how the NPM install behaves. It's been fairly low on my list since I don't develop in AngularJS anymore (having moved to Angular5). If we get some confirmation that it looks good I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #95