chore: close #8 (#16) #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add codeowners file * feat: yoink and modify my workflow * feat: use config file fro versioning * chore: move files because vsc is stupid * chore: move codeowners file * chore: swap out get next version action * fix: that might just work again like this, who knows * fix: see if this approach is saner * fix: bump some stuff and add empty view * fix: use xcode 16.2 * fix: zip app since we're not signing it * chore: fix this * fix: fix workflow * chore: adjust codeowners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR comprises several chore and feature updates aimed at streamlining versioning, build configuration, and release automation.
- Introduces an EmptyView-based window group in the main app for temporary or minimalist UI handling.
- Adds a new configuration file (Config.xcconfig) and updates the Xcode project settings to utilize dynamic version and build number variables.
- Implements a new GitHub workflow for building, version bumping, and releasing the app, along with updates to CODEOWNERS and Dependabot configurations.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| iRPC/iRPCApp.swift | Added a WindowGroup with EmptyView as the root view. |
| iRPC/Config.xcconfig | Introduced config file with BUILD_NUMBER and VERSION definitions. |
| iRPC.xcodeproj/xcuserdata/adrian.xcuserdatad/xcschemes/xcschememanagement.plist | Added new scheme management settings. |
| iRPC.xcodeproj/project.pbxproj | Updated build settings to reference the new config file and use dynamic version variables. |
| .github/workflows/main.yml | Added a comprehensive workflow for build, version bump, changelog generation, and release. |
| .github/dependabot.yml | Configured Dependabot for GitHub Actions. |
| .github/CODEOWNERS | Updated CODEOWNERS file with designated code owner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add codeowners file
feat: yoink and modify my workflow
feat: use config file fro versioning
chore: move files because vsc is stupid
chore: move codeowners file
chore: swap out get next version action
fix: that might just work again like this, who knows
fix: see if this approach is saner
fix: bump some stuff and add empty view
fix: use xcode 16.2
fix: zip app since we're not signing it
chore: fix this
fix: fix workflow
chore: adjust codeowners