Александра Лисицына М3335 #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underoot
requested changes
Mar 27, 2019
underoot
left a comment
underoot
left a comment
There was a problem hiding this comment.
Прошу все-таки привести верстку к макету. Сейчас очень много несоответствий (по размерам, отступам, логотипу и т.п.)
node_modules и .idea следует убрать из системы контроля версий
После добавления писем, при открытии одного из них наблюдается такое:
Удаление сейчас по сути не работает, а анимации вовсе нет
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
mail.html
Outdated
| <div class="menu"> | ||
| <div class="menu__button_write">Написать</div> | ||
| <div class="options"> | ||
| <div class="option options__option1">Входящие</div> |
mail.html
Outdated
| </body> | ||
| </html> | ||
|
|
||
| <script> |
mail.html
Outdated
| </html> | ||
|
|
||
| <script> | ||
| var button_write = document.getElementsByClassName('menu__button_write')[0]; |
mail.html
Outdated
| document.getElementsByClassName('letters')[0].insertBefore(newLetter, letters[0]);}); | ||
| var letters = document.getElementsByClassName('letter'); | ||
| for (var i = 0; i < letters.length; i++) { | ||
| letters[i].addEventListener("click", () => {this.parrentNode.removeChild(this);}) |
There was a problem hiding this comment.
Что здесь this и почему у него должен появиться parrentNode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.