Яковлев Илья M3339 #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Новое сообщение добавляется нажатием 'n', старые сообщения удаляются на 'd'. |
underoot
requested changes
Mar 26, 2019
js/app.js
Outdated
| } | ||
|
|
||
| var currentMessage = messages[index]; | ||
| currentMessage.setAttribute("state", "deleted"); |
There was a problem hiding this comment.
Кастомные аттрибуты у узлов лучше сторить в неймспейсе data-*
js/app.js
Outdated
|
|
||
| var currentMessage = messages[index]; | ||
| currentMessage.setAttribute("state", "deleted"); | ||
| var parent = currentMessage.parentNode; |
css/animations.css
Outdated
| border-width: 0px; | ||
| } | ||
|
|
||
| @keyframes appearance { |
There was a problem hiding this comment.
Можно анимацию для добавления письма организовать через transition
js/app.js
Outdated
|
|
||
| function newMessage() { | ||
| var currentMessage = document.getElementsByClassName("mailbox__mail")[0]; | ||
| if (currentMessage.getAttribute("state") != "hidden") { |
There was a problem hiding this comment.
Хорошо бы проработать кейс добавления не одного письма а нескольких
| @@ -0,0 +1,36 @@ | |||
| document.onkeypress = function(event) { | |||
| if (event.key == 'n') { | |||
There was a problem hiding this comment.
Кроме клавиатурных сокращений попробуй организовать удаление писем по выделенным при нажатии на кнопку-ссылку Удалить
underoot
reviewed
Apr 5, 2019
js/app.js
Outdated
| return; | ||
| } | ||
| currentMessage.setAttribute("state", "showing"); | ||
| setTimeout(function() { |
There was a problem hiding this comment.
Можно повесить обработчик на событие окончания анимации animationend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.