-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/3556 dependency updates and maintenance #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/3556 dependency updates and maintenance #28
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #28 +/- ##
==========================================
Coverage 74.26% 74.26%
Complexity 62 62
==========================================
Files 1 1
Lines 171 171
==========================================
Hits 127 127
Misses 44 44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jekuaitk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one suggestion.
| $decoded = base64_decode(strtr($input, '-_', '+/')); | ||
|
|
||
| /* @phpstan-ignore identical.alwaysFalse */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If i understand https://www.php.net/manual/en/function.base64-decode.php correctly, base64_decode will never return false unless it is set to strict.
| $decoded = base64_decode(strtr($input, '-_', '+/')); | |
| /* @phpstan-ignore identical.alwaysFalse */ | |
| $decoded = base64_decode(strtr($input, '-_', '+/'), true); |
Uh oh!
There was an error while loading. Please reload this page.