Skip to content

Conversation

@turegjorup
Copy link
Collaborator

@turegjorup turegjorup commented Jan 10, 2025

  • Removed support for PHP 8.1 and 8.2
  • Changed from Psalm to PHPStan
  • Upgrade to PHPUnit 11

@turegjorup turegjorup self-assigned this Jan 10, 2025
@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.26%. Comparing base (39a1c8f) to head (aa58300).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #28   +/-   ##
==========================================
  Coverage      74.26%   74.26%           
  Complexity        62       62           
==========================================
  Files              1        1           
  Lines            171      171           
==========================================
  Hits             127      127           
  Misses            44       44           
Flag Coverage Δ
Unit 74.26% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turegjorup turegjorup requested a review from jekuaitk January 10, 2025 12:58
@turegjorup turegjorup changed the title Feature/3556 dependency updatesand maintenance Feature/3556 dependency updates and maintenance Jan 10, 2025
Copy link
Collaborator

@jekuaitk jekuaitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion.

Comment on lines 405 to 407
$decoded = base64_decode(strtr($input, '-_', '+/'));

/* @phpstan-ignore identical.alwaysFalse */
Copy link
Collaborator

@jekuaitk jekuaitk Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i understand https://www.php.net/manual/en/function.base64-decode.php correctly, base64_decode will never return false unless it is set to strict.

Suggested change
$decoded = base64_decode(strtr($input, '-_', '+/'));
/* @phpstan-ignore identical.alwaysFalse */
$decoded = base64_decode(strtr($input, '-_', '+/'), true);

@turegjorup turegjorup merged commit 8589bc9 into develop Jan 11, 2025
11 checks passed
@turegjorup turegjorup deleted the feature/3556_dependency_updatesand_maintenance branch January 11, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants