fix: drag-and-drop uploads #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues with drag-and-drop uploads by updating the Upload component’s structure and integrating a new drop zone element while also adding supporting styles and event handlers.
- Modified Upload.vue to separate the browse and dropzone elements and added drag event listeners
- Updated Backup.vue to include an element with the id "statamic-backup" that serves as the drop container
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| client/src/components/Upload.vue | Updated drag-and-drop logic and DOM element assignments |
| client/src/components/Backup.vue | Added an id to the container to serve as the dropzone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to restore and style drag-and-drop uploads by adding a persistent dropzone wrapper, a drag notification overlay, and wiring up drag/drop events.
- Moved the dropzone wrapper out of the original v-if so it’s always present for event binding.
- Introduced a
.drag-notificationoverlay that appears while dragging files. - Added dragenter/leave/drop event listeners and updated Resumable.js assignments to target the new wrapper.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| client/src/components/Upload.vue | Restructured dropzone wrapper, added drag-notification markup/styles, event listeners, and Resumable.js assign/unassign logic. |
| client/src/components/Backup.vue | Wrapped content in a div with id="statamic-backup" for the drop target. |
Comments suppressed due to low confidence (1)
client/src/components/Backup.vue:2
- [nitpick] Using a generic
idcan lead to conflicts if multiple backup components are rendered. Consider a more specific or dynamic identifier or rely on$refsto scope the drop target.
<div class="relative" id="statamic-backup">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drag and drop uploads doesn't work as they should, this PR adds some styles to it aswell (how good it works i do not know)