feat: make upload chunksize configurable #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a configurable upload chunk size to allow runtime adjustment of file upload parameters.
- Added a chunkSize option in Upload.vue that fetches its value from window.backup.
- Introduced a chunkSize prop in Backup.vue with a set default value.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| client/src/components/Upload.vue | Uses window.backup.chunkSize with a fallback value of 1MB. |
| client/src/components/Backup.vue | Adds a chunkSize prop (default 1MB) and assigns it to window.backup. |
Files not reviewed (2)
- config/backup.php: Language not supported
- resources/views/backups.blade.php: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config option for
chunk_size, which controls the uploads.The default is set to 2mb, which is the default php
upload_max_filesize.