Migrate to new architecture [bad] #31

jonastemplestein · 2025-12-06T23:46:31Z

Integrate the new actor-based architecture into src/ and remove the src/new-architecture folder, establishing it as the main architecture.

Linear Issue: ITE-3285

Note

Replaces legacy context services with an event-sourced MiniAgent architecture, revamps CLI/TUI and HTTP interfaces, and updates docs/tests accordingly.

Core Architecture:
- Introduces event-sourced actor model: domain.ts (events/types), mini-agent.ts, agent-registry.ts, event-reducer.ts, event-store.ts + event-store-fs.ts, and llm-turn.ts.
- Removes legacy context stack (context.model.ts, context.repository.ts, context.service.ts, llm.ts) and unifies errors.
- Context naming simplified (makeContextName returns agentName), file storage under .mini-agent/contexts.
CLI:
- Refactors chat command with explicit --mode (tui|script|piped|auto), improved script input (JSONL), piped and single-turn flows, and optional image attachments.
- Updates TUI (opentui-chat.tsx) and chat-ui.ts to consume new ContextEvents via AgentRegistry.
- Rewires main entry/layers (cli/main.ts) to new services and telemetry.
HTTP & Integrations:
- Replaces /context/:name with POST /agent/:agentName (JSON body), SSE now streams historical + current turn events.
- Updates LayerCode webhook adapter to use AgentRegistry and stream responses.
Docs:
- README updated for modes, options, event types, and HTTP endpoints.
Tests:
- Updates E2E/unit tests to new events and endpoints; adds EventStore tests; removes old new-architecture scaffolding.

^{Written by Cursor Bugbot for commit 73bf894. This will update automatically on new commits. Configure here.}

Co-authored-by: jonas <jonas@nustom.com>

cursor · 2025-12-06T23:46:32Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

linear · 2025-12-06T23:46:35Z

ITE-3285 Make new-architecture the main architecture

src/layercode/layercode.adapter.ts

cursor · 2025-12-06T23:53:29Z

src/event-reducer.ts

+        case "FileAttachmentEvent": {
+          // File attachments are handled during LLM request, not stored in messages
+          return { ...ctx, nextEventNumber }
+        }


Bug: File attachments never sent to LLM

The FileAttachmentEvent case in the reducer says "handled during LLM request, not stored in messages" and only increments nextEventNumber. However, llm-turn.ts has no file handling code - the contextToPrompt function simply converts ctx.messages to a prompt. Since file attachments are never added to messages and the LLM turn doesn't process them separately, images and files added via the --image CLI flag are persisted but never actually included in LLM requests. The old deleted llm.ts had explicit code to read files and add them as Prompt.filePart - this functionality is missing from the new architecture.

Additional Locations (1)

src/llm-turn.ts#L26-L27

This commit introduces explicit CLI modes (tui, script, piped, auto) and refactors event handling to provide more detailed output and better TUI integration. Co-authored-by: jonas <jonas@nustom.com>

cursor

Bug: Interrupted turn partial response not added to LLM context

The AgentTurnInterruptedEvent case in the event reducer doesn't add the partialResponse to the messages array. In the old architecture, when an LLM response was interrupted, the partial response was included as an assistant message and a user message explaining the interruption was added. Without this, the LLM loses context about what was said before the interruption. The test comment at line 432 in test/cli.e2e.test.ts explicitly expects this behavior but the reducer only clears turn state without preserving the partial response content.

src/event-reducer.ts#L138-L146

mini-agent/src/event-reducer.ts

Lines 138 to 146 in e032075

    
           case "AgentTurnInterruptedEvent": 
        
           case "AgentTurnFailedEvent": { 
        
             // Turn ended (failed or interrupted) - clear in-progress state 
        
             return { 
        
               ...ctx, 
        
               agentTurnStartedAtEventId: Option.none(), 
        
               nextEventNumber 
        
             }

cursor · 2025-12-07T00:04:51Z

src/cli/chat-ui.ts

    )

+    // Add event to trigger LLM turn
+    yield* agent.addEvent(userEvent)


Bug: Missing delay causes race condition in event subscription

The code subscribes to agent.events with Effect.fork and immediately calls agent.addEvent without waiting for the subscription to be active. Since broadcastDynamic doesn't replay events, late subscribers miss events. Other locations in the codebase (src/cli/commands.ts line 395 and src/http.ts line 123) correctly add Effect.sleep("10 millis") after forking to ensure the subscription is ready. Without this delay, the UserMessageEvent and subsequent LLM response events may be missed by the subscriber.

Additional Locations (2)

src/layercode/layercode.adapter.ts#L168-L183

src/cli/commands.ts#L259-L267

Co-authored-by: jonas <jonas@nustom.com>

cursor · 2025-12-07T06:46:47Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

jonastemplestein

@cursor fix

jonastemplestein · 2025-12-07T06:44:12Z

src/cli/commands.ts


    if (options.raw) {
-      if (Schema.is(TextDeltaEvent)(event) && !options.showEphemeral) {
+      if (event._tag === "TextDeltaEvent" && !options.showEphemeral) {


Why are you using _tag directly? That seems wrong! Isn't Schema.is more idiomatic?

jonastemplestein · 2025-12-07T06:45:14Z

src/cli/commands.ts

+  }
+
+  // --script flag is alias for --mode script
+  if (options.script) {


We don't need this option anymore?

jonastemplestein · 2025-12-07T06:46:09Z

src/cli/commands.ts

+})
+const SimpleSystemPrompt = Schema.Struct({
+  _tag: Schema.Literal("SystemPrompt"),
+  content: Schema.String


No this is rubbish - there should be functions on the actual schemas to create them from
Just a message

jonastemplestein · 2025-12-07T06:46:50Z

src/cli/commands.ts

 )

-const scriptInteractiveLoop = (contextName: string, options: OutputOptions) =>
+const isUserMessage = (e: ScriptInputEvent): e is typeof UserMessageEvent.Type | typeof SimpleUserMessage.Type =>


Rubbish. Delete

Should be schema.is (though the whole helper function here should be deleted)

jonastemplestein · 2025-12-07T06:47:05Z

src/cli/commands.ts

-          if (Schema.is(UserMessageEvent)(event)) {
-            yield* contextService.addEvents(contextName, [event]).pipe(
-              Stream.runForEach((outputEvent) => handleEvent(outputEvent, options))
+          if (isUserMessage(event)) {


jonastemplestein · 2025-12-07T06:52:47Z

src/cli/commands.ts

+    yield* Effect.logDebug("Starting chat session", { mode, explicitMode: options.mode })
+
    const contextName = Option.getOrElse(options.name, generateRandomContextName)
+    const agentName = contextName as AgentName


Type assertion? Is there no better way to do this in effect?

jonastemplestein · 2025-12-07T06:53:36Z

src/cli/commands.ts

-      yield* Console.log("  POST /context/:contextName")
-      yield* Console.log("       Send JSONL events, receive SSE stream")
-      yield* Console.log("       Content-Type: application/x-ndjson")
+      yield* Console.log("  POST /agent/:agentName")


Add GET on same path to just tap into event stream

jonastemplestein · 2025-12-07T06:56:45Z

src/cli/components/opentui-chat.tsx

 type FeedItem = typeof FeedItem.Type

-type FeedAction = { event: ContextEvent; isHistory: boolean }
+type FeedAction = { event: ChatEvent; isHistory: boolean }


No this is a pointless abstraction

Instead of Chat we want to use AgentTUIFeed

And AgentTUIFeedItem

And there should be no FeedAction

Instead the AgentTUIFeedItem base schema should have isHistory

Everything has isHistory true except for the feed items after the last session started event

Probably needs a finalizer or something that runs after the reducer to determine this

jonastemplestein · 2025-12-07T06:58:18Z

src/cli/components/opentui-chat.tsx

 const FeedItemRenderer = memo<{ item: FeedItem }>(({ item }) => {
+  if (!("_tag" in item)) return null
+
  switch (item._tag) {


See if there is a more idiomatic way to do this in effect.schema

jonastemplestein · 2025-12-07T06:59:54Z

src/domain.ts

      durationMs
+    }),
+
+  textDelta: (


What is this EventBuilder pattern?

Check the effect source code to see if there is a more idiomatic way to e.g. put these factory methods on the Schemas themselves

cursor · 2025-12-07T07:00:54Z

Addressed the interruption gap: AgentTurnInterruptedEvent now injects the partial assistant text (if any) plus an explanatory user message describing why the previous response stopped. This mirrors the legacy behavior expected by test/cli.e2e.test.ts and keeps downstream LLM turns aware of what was already said before the interruption.

_{Learn more about Cursor Agents}

jonastemplestein

@cursor please fix comments

cursor · 2025-12-07T07:16:14Z

On it. Already fixed the interrupted-turn gap (AgentTurnInterruptedEvent now emits the partial assistant message plus the explanatory user message), and I’m now working through the remaining review comments in commands.ts and opentui-chat.tsx—will swap the ad-hoc helpers over to Schema.is, rework the raw/streaming flow per your notes, and revisit the feed abstraction once the reducer-side support is ready.

_{Learn more about Cursor Agents}

Refactor: Migrate to new actor architecture

bbf328e

Co-authored-by: jonas <jonas@nustom.com>

jonastemplestein marked this pull request as ready for review December 6, 2025 23:46

cursor bot reviewed Dec 6, 2025

View reviewed changes

Refactor: Improve CLI modes and event handling

e032075

This commit introduces explicit CLI modes (tui, script, piped, auto) and refactors event handling to provide more detailed output and better TUI integration. Co-authored-by: jonas <jonas@nustom.com>

cursor bot reviewed Dec 7, 2025

View reviewed changes

feat: Handle AgentTurnInterruptedEvent with partial responses

73bf894

Co-authored-by: jonas <jonas@nustom.com>

jonastemplestein commented Dec 7, 2025

View reviewed changes

jonastemplestein changed the title ~~Migrate to new architecture~~ Migrate to new architecture [bad] Dec 7, 2025


	case "AgentTurnInterruptedEvent":
	case "AgentTurnFailedEvent": {
	// Turn ended (failed or interrupted) - clear in-progress state
	return {
	...ctx,
	agentTurnStartedAtEventId: Option.none(),
	nextEventNumber
	}

Migrate to new architecture [bad] #31

Are you sure you want to change the base?

Migrate to new architecture [bad] #31

Uh oh!

Conversation

jonastemplestein commented Dec 6, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Dec 6, 2025

Uh oh!

linear bot commented Dec 6, 2025

Uh oh!

Uh oh!

cursor bot Dec 6, 2025

Choose a reason for hiding this comment

Bug: File attachments never sent to LLM

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: Interrupted turn partial response not added to LLM context

Uh oh!

cursor bot Dec 7, 2025

Choose a reason for hiding this comment

Bug: Missing delay causes race condition in event subscription

Uh oh!

cursor bot commented Dec 7, 2025

Uh oh!

jonastemplestein left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonastemplestein left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonastemplestein commented Dec 6, 2025 •

edited by cursor bot

Loading

cursor bot commented Dec 7, 2025 •

edited

Loading

cursor bot commented Dec 7, 2025 •

edited

Loading