Skip to content

Comments

authentication flow and blame#62

Open
itepastra wants to merge 14 commits intomainfrom
auth
Open

authentication flow and blame#62
itepastra wants to merge 14 commits intomainfrom
auth

Conversation

@itepastra
Copy link
Owner

Adds a start for an OAUTH based authentication flow, there is a feature flag to enable it.

@itepastra itepastra changed the title authentication flow authentication flow and blame Dec 11, 2024
@itepastra itepastra marked this pull request as ready for review December 11, 2024 21:40
@itepastra itepastra requested a review from peppidesu December 11, 2024 21:40
Copy link
Owner Author

@itepastra itepastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some guidance comments

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial

Copy link
Owner Author

@itepastra itepastra Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for me to make reqwest working, don't worry

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this one you may care about. It's close to a copy from grid tho

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this url should probably be changed or be like cli configurable

x,
y,
c,
#[cfg(feature = "auth")]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is annoying but needed to have the tests work with --features auth as well


pub async fn process_socket(&mut self) -> io::Result<()> {
// Handle the auth flow
#[cfg(feature = "auth")]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be redone at some point, or at least depend on the other side

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all relatively trivial changes

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

save 2 files each loop, the state and the blame map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant