Skip to content

chore: migrate to vp#54

Closed
fengmk2 wants to merge 1 commit intoitaymendel:mainfrom
fengmk2:migrate-to-vp
Closed

chore: migrate to vp#54
fengmk2 wants to merge 1 commit intoitaymendel:mainfrom
fengmk2:migrate-to-vp

Conversation

@fengmk2
Copy link

@fengmk2 fengmk2 commented Mar 8, 2026

Summary by CodeRabbit

  • New Features

    • Integrated vite-plus as the primary development and tooling platform.
  • Configuration

    • Migrated linting from oxlint to vite-plus for code quality checks.
    • Updated build and test configuration files for vite-plus compatibility.
    • Modified pre-commit hooks to use new linting approach.
    • Reorganized package configuration with updated dependencies.
  • Documentation

    • Added development guides and collaboration guidelines.

@fengmk2 fengmk2 closed this Mar 8, 2026
@fengmk2 fengmk2 deleted the migrate-to-vp branch March 8, 2026 08:48
@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fddd288d-c6ed-4a03-8104-42677ca37f91

📥 Commits

Reviewing files that changed from the base of the PR and between 439d7df and d0c1c02.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (21)
  • .claude/settings.json
  • .claude/skills/vite-plus
  • .husky/pre-commit
  • .oxlintrc.json
  • .vite-hooks/pre-commit
  • AGENTS.md
  • CLAUDE.md
  • package.json
  • tests/breakdown.test.ts
  • tests/complexity.test.ts
  • tests/extraction-flow.test.ts
  • tests/extraction-mutations.test.ts
  • tests/extraction.test.ts
  • tests/fixtures/js/extraction-candidate.js
  • tests/fixtures/svelte/complex-logic.svelte
  • tests/fixtures/svelte/typescript-component.svelte
  • tests/minlines.test.ts
  • tests/utils/extraction-helpers.ts
  • tests/utils/fixture-loader.ts
  • vite.config.ts
  • vitest.config.ts

📝 Walkthrough

Walkthrough

This PR migrates the project from oxlint-based linting to vite-plus as the primary infrastructure for building, linting, and testing. It removes oxlint configuration, introduces vite and vitest configuration files, updates test imports across the suite, reorganizes package.json dependencies and scripts, and adds new vite-hooks for pre-commit quality checks.

Changes

Cohort / File(s) Summary
Configuration Infrastructure
.claude/settings.json, .claude/skills/vite-plus, .vite-hooks/pre-commit, vite.config.ts, vitest.config.ts
Adds vite-plus MCP server configuration and vite-hooks pre-commit script. Introduces new vite.config.ts with lint rules, staged command, and ignore patterns. Changes vitest.config.ts import source from vitest/config to vite-plus.
Build & Dependency Management
package.json, .oxlintrc.json
Removes entire oxlint configuration file. Reorganizes package.json: adds homepage, bugs.url, files array, main, types, and exports fields; updates scripts to use vp commands; replaces vite/vitest dependencies with @voidzero-dev equivalents via pnpm overrides; adds @oxlint/plugins to devDependencies; sets packageManager to pnpm@10.26.2.
Pre-commit Hook Migration
.husky/pre-commit
Replaces oxlint linting step with vp lint command while preserving format check, TypeScript emit check, and test steps.
Documentation
AGENTS.md, CLAUDE.md
Adds new AGENTS.md with extensive Markdown documentation content. Minor reference addition to CLAUDE.md.
Test Framework Imports
tests/breakdown.test.ts, tests/complexity.test.ts, tests/extraction-flow.test.ts, tests/extraction-mutations.test.ts, tests/extraction.test.ts, tests/minlines.test.ts
Updates import source from vitest to vite-plus/test across all test files. Changes Array.prototype.sort to toSorted in sorting-dependent comparisons. Removes non-null assertions on loc property accesses.
Test Utilities
tests/utils/extraction-helpers.ts, tests/utils/fixture-loader.ts
Removes non-null assertions from result.node.loc property accesses in extraction helpers. Replaces sort() with toSorted() in fixture loading.
Test Fixtures
tests/fixtures/js/extraction-candidate.js, tests/fixtures/svelte/complex-logic.svelte, tests/fixtures/svelte/typescript-component.svelte
Changes variable declarations from let to const while preserving array mutation patterns and test behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Hops through configs with vite-plus in paw,
Old oxlint chains now break without a flaw,
From let to const, and sort to toSorted,
Pre-commit hooks and tests have been sorted,
A tooling migration, both swift and precise!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengmk2
Copy link
Author

fengmk2 commented Mar 8, 2026

I'm very sorry for the inconvenience caused by submitting the PR to the wrong repo.

@fengmk2 fengmk2 restored the migrate-to-vp branch March 8, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant