Skip to content

wallet attestations#531

Merged
peppelinux merged 12 commits intodevfrom
feature/wallet_attestation
Mar 22, 2026
Merged

wallet attestations#531
peppelinux merged 12 commits intodevfrom
feature/wallet_attestation

Conversation

@manpace
Copy link
Member

@manpace manpace commented Mar 13, 2026

wallet app attestation
wallet app attestation request
wallet unit attestation

@manpace manpace requested a review from peppelinux March 13, 2026 11:49
@manpace manpace changed the title Feature/wallet attestations wallet attestations Mar 13, 2026
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lib must be renamed in a more general way

wallet_attestations instead of wallet_instance_attestation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 7165263

Copy link
Member Author

@manpace manpace Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for renaming the module to wallet_attestations. I had initially changed it from wallet_instance_attestation to wallet_instance_attestations but the new naming is definitely more appropriate.

@peppelinux
Copy link
Member

@manpace the CI is broken and the componest is still not renamed to wallet_attestations after more than 2 weeks

doing it by myself, I would ask you when possible the reasons about these performance

@peppelinux
Copy link
Member

@manpace the content of this PR was still misaligned with both eudiw ARF and it-wallet specs

  • x5c is mandatory in wia jtw header
  • the typ of both wia and wa request was misaligned
  • the sign alg cannot be RS256

I have fixed these in my last three commits, I also have included comments to evidence from where these changes came from, in term of normative references.

@peppelinux peppelinux marked this pull request as ready for review March 22, 2026 16:54
@peppelinux peppelinux merged commit 71e688e into dev Mar 22, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants