Closed
Conversation
* feat: direct_post input normalization * fix: test bug
Added client metadata in authorization request and prevent private key leakage
Public Key Test DirectTrustJar
PascalDR
added
enhancement
…llet-it-python into feat/mdoc_support
Member
|
this PR must use the updates introduced by the EUDIW ref impl here: IdentityPython/pyMDOC-CBOR#8 they have unfortunately removed the CI (!) therefore I need you engaged in the general review of the pending PR and the fix of the failing tests (there) |
peppelinux
reviewed
Mar 18, 2025
| response_uri: str, | ||
| authorization_config: dict, | ||
| nonce: str = "", | ||
| metadata: dict = None, |
Member
There was a problem hiding this comment.
Suggested change
| metadata: dict = None, | |
| metadata: dict = {}, | |
peppelinux
reviewed
Mar 18, 2025
peppelinux
reviewed
Mar 18, 2025
peppelinux
reviewed
Mar 18, 2025
Comment on lines
-235
to
+174
| all_attributes = self._extract_all_user_attributes(attributes_by_issuer) | ||
| if is_sd_jwt_kb_format(vp_token): |
Member
There was a problem hiding this comment.
this part must be refactored, since the RP know what it has previously requested using presentation definition or duckle query language
peppelinux
requested changes
Mar 18, 2025
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
we need to use presentation submission or duckle query to map which vp token entry matches the corresponding credential format
Contributor
Author
|
The changes of this pr are moved on the PR #391 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #387
Resolves #114
The changes of this pr are moved on the #391