Refactor: Modernize budget viewer state with Signals#185
Open
IsaacVic-Dark wants to merge 1 commit intoitalanta:mainfrom
Open
Refactor: Modernize budget viewer state with Signals#185IsaacVic-Dark wants to merge 1 commit intoitalanta:mainfrom
IsaacVic-Dark wants to merge 1 commit intoitalanta:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly explain how you went about this assignment and the key benefits of using
Signals over the previous RxJS approach in this UI scenario.
i approached this assignment by getting deep insight on Signals and RxJS. i first replaced constructors with inject(), converted Observables to signal(), used computed(), replaced subscribe() with effect() and used ChangeDetectionStrateg.OnPush in to remove subscription based change.
Some of the benefits is that no subscription is needed, this is beneficial since sometimes developers forget to unsubscribe leading to memory leaks.
signals are synchronous by default, this avoids unnecessary async overhead UI state.
Explain how you understand the difference in coding styles between the two.
for RxJS developer must remember to unsubscribe to prevent memory leaks but for signals, angulars manages the effect lifecycle
Explain how signals and observables works and if there’s a fundamental
difference between the two
signals, updates and values happen immediately, synchronous in nature while in observables, you must subscribe first and operations are handled asychronously
Mention an example of another coding paradighm or style you’ve used in the
past. What is better/worse about that one?
i have used declarative programming in React. for example where i display list of lets say user in UI using map.
advantages of this:
its easy to read and automatically updates the UI
disadvantages of this:
developer does not have much control over how things are updated.