Remove unused NaN_d import from test_stdface_main_helpers.py#57
Merged
k-yoshimi merged 3 commits intofeature/solver-plugin-architecturefrom Jan 29, 2026
Merged
Conversation
Co-authored-by: k-yoshimi <4516893+k-yoshimi@users.noreply.github.com>
Co-authored-by: k-yoshimi <4516893+k-yoshimi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on lattice plugin architecture
Remove unused NaN_d import from test_stdface_main_helpers.py
Jan 29, 2026
k-yoshimi
merged commit cfe2198
into
feature/solver-plugin-architecture
12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on PR #53 regarding an unused import in the test file.
Changes
NaN_dimport fromtest/unit/test_stdface_main_helpers.py.gitignoreto exclude Python build artifacts (*.egg-info/,dist/,*.egg)The test file imports
NaN_dfromstdface.core.stdface_valsbut never references it. This import was likely carried over during test extraction and is unnecessary for the test suite.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.