Skip to content

Add explanatory comment for ImportError handling in plugin discovery #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k-yoshimi merged 4 commits into from
Jan 29, 2026
Merged

Add explanatory comment for ImportError handling in plugin discovery #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a91d406
Initial plan
Copilot Jan 29, 2026
c275b74
Add explanatory comment for ImportError handling in _discover_plugins
Copilot Jan 29, 2026
f1e350e
Remove egg-info build artifacts and update .gitignore
Copilot Jan 29, 2026
9a0fa4f
Merge branch 'feature/solver-plugin-architecture' into copilot/sub-pr…
k-yoshimi Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ cmake-build-debug/
__pycache__/
*.pyc

# Python build artifacts
# Python package metadata
*.egg-info/
dist/
*.egg
Expand Down
3 changes: 3 additions & 0 deletions python/stdface/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,4 +262,7 @@ def _discover_plugins() -> None:
try:
import stdface.solvers # noqa: F401 — triggers auto-registration
except ImportError:
# Solvers package not available (e.g., minimal install, missing
# dependencies, or corrupted package). Plugin lookup will fail
# with a helpful KeyError listing available plugins.
pass