fixed bug in output of two-body Green functions#200
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the bug where the two-body Green's function was output unexpectedly during the computation of higher-order Green’s functions. Key changes include:
- Wrapping the file open operation for the two-body Green’s function in a conditional block.
- Similarly adding a conditional block to close the file pointer only when the condition is met.
- Removing a commented-out debug print statement.
Comments suppressed due to low confidence (2)
src/expec_cisajscktaltdc.c:157
- [nitpick] Consider adding an inline comment to explain why the file open operation is conditional on NCisAjtCkuAlvDC to improve code clarity and maintainability.
if(X->Def.NCisAjtCkuAlvDC>0){
src/expec_cisajscktaltdc.c:217
- [nitpick] It may be helpful to add a comment here to clarify that the file is only closed when it was opened under the NCisAjtCkuAlvDC condition, ensuring maintainability and clarity about the file handling logic.
if(X->Def.NCisAjtCkuAlvDC>0){
Contributor
|
@tmisawa src/expec_cisajscktaltdc.c:157
src/expec_cisajscktaltdc.c:217
|
Contributor
Author
|
@k-yoshimi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a bug where the two-body Green's function was being output even when not explicitly specified,
while trying to compute the three-, four-, and six-body Green's functions.