Skip to content

Conversation

@stufisher
Copy link
Collaborator

Related sql changes:
https://github.com/DiamondLightSource/ispyb-database/pull/63/files

Could be made more optional by checking if tables exist

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #256 (36e4576) into master (c45a43a) will decrease coverage by 0.44%.
The diff coverage is 49.65%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   65.89%   65.45%   -0.44%     
==========================================
  Files         112      112              
  Lines        5313     5454     +141     
==========================================
+ Hits         3501     3570      +69     
- Misses       1812     1884      +72     
Impacted Files Coverage Δ
pyispyb/core/modules/containers.py 18.26% <14.70%> (-9.24%) ⬇️
pyispyb/core/routes/containers.py 50.81% <40.74%> (-9.19%) ⬇️
pyispyb/core/schemas/containers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c45a43a...36e4576. Read the comment docs.

@mgaonach
Copy link
Collaborator

mgaonach commented Feb 8, 2023

How are the queues created? Do we not need a POST route for that?

@stufisher
Copy link
Collaborator Author

stufisher commented Feb 8, 2023

daiquiri populates this directly, but yes, for mxcube you'd need a resource (and also mxcube would need to link back the datacollection to the related diffractionplan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants