This repository was archived by the owner on Apr 1, 2019. It is now read-only.
Fix BUG performLogin called multiple times #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `enable` caused the policy function to be called for every action dispatched to the store, any action(s) dispatched after performLogin was called and before `state.cognito.state` transitioned from `LOGGING_IN` to something else caused `performLogin` to be called. To fix this bug the store subscription handler checks if `state.cognito.state` has changed and only calls the policy function if it has.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix /issues/35
Since
enablecaused the policy function to be called for every action dispatched to the store, any action(s) dispatched betweenstate.cognito.statetransitions could caused duplicate calls of the policy function.To fix this the store subscription handler checks if
state.cognito.statehas changed and only calls the policy function if it has.