WIP: feat: added the initial implementation of the [jenkins] provider#7
Draft
pcanilho wants to merge 1 commit intoisometry:mainfrom
Draft
WIP: feat: added the initial implementation of the [jenkins] provider#7pcanilho wants to merge 1 commit intoisometry:mainfrom
pcanilho wants to merge 1 commit intoisometry:mainfrom
Conversation
pcanilho
force-pushed
the
feature/provider-jenkins
branch
4 times, most recently
from
9bc691f to
6b149e3
Compare
isometry
reviewed
Apr 3, 2024
| credential objects which aims at populating the `username` and `token` fields. Multiple credentials providers can be used. | ||
| If multiple credentials providers are used, the `username` and `token` fields are populated by merging the provider results. | ||
|
|
||
| ## Credentials provider support |
Owner
There was a problem hiding this comment.
I love the idea, but I'm a little wary of re-using the "provider" terminology here. Maybe "credentials source" rather than "credentials provider", e.g. "Supported Credentials Sources"
isometry
reviewed
Apr 3, 2024
| detail: true | ||
| credentials: | ||
| - provider: vault | ||
| address: https://vault.com |
Owner
There was a problem hiding this comment.
Were we to add a Vault credentials source, then I think that address would belong in it, rather than per (component-)provider-instance =)
pcanilho
force-pushed
the
feature/provider-jenkins
branch
from
6b149e3 to
e7b58f4
Compare
pcanilho
force-pushed
the
feature/provider-jenkins
branch
from
e7b58f4 to
3480375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.