Conversation
Update DNS provider to support SRV, SOA, and PTR record lookups. Switch config key from kind to type. Add detailed record tests. Upgrade dependencies and set default timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces DNS health check support to the platform-health server, enabling DNS query validation and response inspection as a new provider. The changes include adding the DNS provider implementation, updating build and dependency files, and generating protocol buffer code for DNS details.
DNS Provider Implementation:
cmd/ph/main.goandcmd/phs/main.go, and comprehensive documentation inpkg/provider/dns/README.md. This enables DNS checks as part of platform-health and explains configuration, CEL checks, and usage. [1] [2] [3]Protocol Buffer and Build Integration:
pkg/platform_health/details/detail_dns.pb.gofor DNS detail messages, and updated theMakefileto include DNS proto generation steps. [1] [2] [3]Dependency Updates:
github.com/miekg/dnsas a direct dependency for DNS functionality, and updated several other dependencies for compatibility and security. Notably, bumped Go version to 1.26.0 and updatedgoogle.golang.org/grpc,github.com/clipperhouse/uax29/v2, and indirect dependencies. [1] [2] [3] [4] [5] [6]