Skip to content

Update Database.java #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Revivius wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Database.java #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/Database.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
* @author ismet abacı
*/
public class Database {
// GG:
// Neden private değiller ?
final static Logger logger = Logger.getLogger(String.valueOf(MyThread.class));
String url ;
String databaseName ;
Expand All @@ -33,7 +35,11 @@ public Database(String url,String databaseName,String userName, String password)
public void insertIntoDatabase(JSONObject msg){
try{
String tableName = (String) msg.get("priority"); //get table name according to the message's priority
// GG:
// Tek satır da olsa blok açılmalı
if (tableName == null) return;
// GG:
// Her seferinde bağlantı açmak mantıklı değil. Başka ne yöntem kullanılabilir ?
connect = DriverManager.getConnection(url + databaseName +"?user="+ userName +"&password=" + password); //WARNING: I used xampp for the db Connection
String sql = "insert into " + tableName + " (id,sender,receiver,subject,cc,message,priority) values (default, ?, ?, ?, ? , ?, ?);";
preparedStatement = connect.prepareStatement(sql);
Expand All @@ -44,7 +50,10 @@ public void insertIntoDatabase(JSONObject msg){
preparedStatement.setString(5, msg.get("message").toString());
preparedStatement.setString(6, msg.get("priority").toString());
preparedStatement.executeUpdate();

}catch(Exception e){
// GG:
// Indent kaymış.
logger.warning("Error on client-db conn -> " + e);
}
}
Expand Down