feat: add scannerUIOptions #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: removes showUi in favor of scannerUiOptions
Owner
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes showUi in favor of scannerUiOptions
this adds a little more customizability. let me know if you think showTorch option is unnecessary and want it removed
in bisq mobile project we have commented out zoom controls, plus we have i18n, which makes the default hardcoded title unfavorable, but it's also unnecessary to create UI from scratch just for that, hence this PR
note: this is just what I think may be an improvement, feel free to discuss and turn down this PR if you think it's not good