Update InSAR to copy statistics from input product#148
Open
nemo794 wants to merge 1 commit intoisce-framework:mainfrom
Open
Update InSAR to copy statistics from input product#148nemo794 wants to merge 1 commit intoisce-framework:mainfrom
nemo794 wants to merge 1 commit intoisce-framework:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #123 .
Currently, for RSLC/GSLC/GCOV, the min/max/mean/std statistics are copied from the input Science Data HDF5 into the QA STATS HDF5. In contrast, these statistics for InSAR products are recomputed by QA and written into the QA STATS HDF5.
As noted in #123, ideally QA would handle these statistics consistently for all eight product types. Because it would be computationally expensive for QA to re-compute these for RSLC/GSLC/GCOV, and because per offline discussion in Dec 2025 there are some uncertainties about how the ISCE3 InSAR workflow will compute these metrics (and it'd be tricky for QA to maintain being in-sync with ISCE3 re: the method of computation), let's simply have QA copy the statistics for InSAR rasters as well.
tl'dr -- this PR updates QA to copy the ISCE3-computed InSAR statistics from the input Science HDF5s into the QA STATS HDF5s.
This PR was tested with all eight product types, with manual spot-checking that values were copied correctly for each raster.