Updated analyzer breaking changes and source_gen dependancies

[callumw-k]

All tests pass, I believe anaylzer depricated these values a while ago and 7.3.0 was the final removal. I don't have any build_runner errors or dependancy issues in my current project.

I've potentially been to liberal here, as I've fixed some dart lint errors as well. Happy to pair back a bit as required

[saropa]

Thank you

[viskanic]

@vicenterusso
Who needs to review this PR to get the ball rolling?

A new release with updated dependencies would be much appreciated.

[vicenterusso]

@vicenterusso Who needs to review this PR to get the ball rolling?

A new release with updated dependencies would be much appreciated.

I'm in the middle of the process of renaming this entire project to isar-community so we can use pub.dev directly. After initial tests I will thoroughly examine all opened PRs

[viskanic]

Great to hear and thank you for the quick reply 👍

If you need any help, please let me know.

[vicenterusso]

Great to hear and thank you for the quick reply 👍

If you need any help, please let me know.

I will certainly need help with testing 😃

[callumw-k]

@vicenterusso let me know if I can help at all, I've got a bit of time to chip in if needed

[jslater89]

@vicenterusso I'm using Isar in a side project I'm getting paid for and would be happy to spend some of that paid time on assisting with testing or maintenance—please let me know as well.

[vicenterusso]

@vicenterusso I'm using Isar in a side project I'm getting paid for and would be happy to spend some of that paid time on assisting with testing or maintenance—please let me know as well.

Sure! Do you develop on Windows or macOS by any chance? I need to find time to test the package renaming on those platforms. Android and Linux have already been renamed.

This is the first step toward addressing all the other open issues.

[jslater89]

@vicenterusso I'm using Isar in a side project I'm getting paid for and would be happy to spend some of that paid time on assisting with testing or maintenance—please let me know as well.

Sure! Do you develop on Windows or macOS by any chance? I need to find time to test the package renaming on those platforms. Android and Linux have already been renamed.

This is the first step toward addressing all the other open issues.

Yup, the application I'm maintaining is for desktop, so I have dev environments set up on both a Mac and a Windows machine along with Linux.

[vicenterusso]

@callumw-k @viskanic @jslater89 @saropa

Hey! This is a bit of a clunky repo (v3 only) that includes a minimal sample and a semi-renamed version of Isar.

Linux and Android are working, but Windows, macOS, and iOS still need some work. I believe only the files inside isar_community_flutter_libs need to be renamed.

The minimal test project is already set up to pull the packages relatively from the current folder (check the pubspec.yaml for details).

Repo: https://github.com/vicenterusso/isar_renaming_test_bundle/

Feel free to open PRs and experiment!

[mosabalrsaheed]

Hi all, any updates on this?!

[angelru]

Any news?

[docaohuynh]

For Who waiting this merge. Change to

  isar_generator: 
    git: 
      url: https://github.com/callumw-k/isar
      ref: v3
      path: packages/isar_generator

[saropa]

Thanks @docaohuynh - really appreciate this

Btw, analyzer is up to v7.4.5 now, which could be beneficial https://pub.dev/packages/analyzer/changelog#745

We're operating on the idea that v4 won't be production-ready for the forseeable future. But in the meantime, a bump to v3 with this and other minor quality-of-life PRs would be really great!

[jrosefab]

Hi! Just a quick follow-up to see if this PR could be reviewed and potentially merged soon 🙏
It would help move things forward on our side — thanks in advance!

[ibrahimdevs]

@vicenterusso this is well waited, hope merged soon 👍

[penhorwood]

Any movement on this PR?

[callumw-k]

Hey @vicenterusso looking at revisiting this to try help get it merged as there seems to be quite a bit of interest. I believe on new flutter versions these changes are required.

Is there anything you'd like me to address?

@saropa @viskanic @jslater89

[vicenterusso]

I guess we should keep the project clean, without fvm files. Everything else looks good to me

[callumw-k]

Yep easy, updated

[penhorwood]

Is it possible to get this pushed over the finish line?

[vicenterusso]

We have 100% of tests failing here. This blocks new releases

[penhorwood]

@callumw-k - It seems this file is missing as this is the error message over and over

Failed to resolve package URI "package:very_good_analysis/analysis_options.yaml" in include.

Version issue
Because every version of flutter_test from sdk depends on test_api 0.7.4 and isar_test depends on test_api ^0.5.1, flutter_test from sdk is forbidden.
So, because isar_test depends on flutter_test from sdk, version solving failed.

There are a few more compiling issues of the Rust code according to the error messages above.

[callumw-k]

I'll try and have a look today depending on how busy I am with work. I'm not sure what tests I ran originally but definitely missed these somehow

[vicenterusso]

I'll try and have a look today depending on how busy I am with work. I'm not sure what tests I ran originally but definitely missed these somehow

I'm working on it too, but will try to update with the minimal code change

[vicenterusso]

This is a kickstart to our package on pubdev:

https://github.com/isar-community/isar-community

For now I updated source_gen with help from @callumw-k's PR #122

This project is a direct continuation from isar-community/isar, so it will be version 3.2.0. Nexts steps:

• Update more packages
• Update for 16KB page size
• Finally publish minimal acceptable version

I really want PRs for that new repo. All tests are passing so we must keep 100% of tests green

[callumw-k]

Should change the flutter_sdk target? It looks like the passing pipelines are running on 3.10.0, which is a large reason for why the tests are failing due to the test_sdk dep contraints etc. I'll have a play around tomorrow and move my pr to the new repo.

Flutter 3.10 was ~2023 release. But I get that it might be a juggle to find a middle ground.

@vicenterusso can you trigger the tests running 3.10? Not sure why it's defaulted to current stable for this pr

Current V3 branch:

This branch:

[callumw-k]

Okay I re-ran the tests on my fork targeting 3.10, we're going to end up in dep hell if we want source_gen 2.0. But, it's late so I'll see how much progress I can make tomorrow

[vicenterusso]

Should change the flutter_sdk target? It looks like the passing pipelines are running on 3.10.0, which is a large reason for why the tests are failing due to the test_sdk dep contraints etc. I'll have a play around tomorrow and move my pr to the new repo.

The new repo has already been updated with your changes! I had to make slight adjustments to the pubspec parts

Edit: Its not updated yet, still working on it

Flutter 3.10 was ~2023 release. But I get that it might be a juggle to find a middle ground.

Exactly. with the recent Flutter version, there’s a version conflict between packages that’s difficult to resolve

[saropa]

I have nothing useful to add, but wanted to say a big thank you to all for your continued support of this important package.

(And if anyone from the Flutter team is viewing these threads ... this is not a serious way to run a non-hobby projects, and you need to get some skin in the game).

[callumw-k]

Should change the flutter_sdk target? It looks like the passing pipelines are running on 3.10.0, which is a large reason for why the tests are failing due to the test_sdk dep contraints etc. I'll have a play around tomorrow and move my pr to the new repo.

The new repo has already been updated with your changes! I had to make slight adjustments to the pubspec parts

Edit: Its not updated yet, still working on it

Flutter 3.10 was ~2023 release. But I get that it might be a juggle to find a middle ground.

Exactly. with the recent Flutter version, there’s a version conflict between packages that’s difficult to resolve

Ah it really is late, I completely missed that you'd bought them in. I'll check in the morning

[callumw-k]

@vicenterusso what's your thoughts on having a branch or a beta build that supports latest versions of flutter/deps? I think the issue people are running into is using freezed & json_annotation, which is all source 2.0.0. However, that requires dart 3.6.0, which is flutter 3.27.0.

I'd be happy to take ownership of getting that branch setup and try to do it as minimally as possible so as to stick with current test suite etc

[vicenterusso]

that requires dart 3.6.0, which is flutter 3.27.0.

Yeah, 3.27.0 is the new minimum for flutter new repo

[callumw-k]

Anyone who's following this thread, might be worth moving the conversation to isar-community/isar-community#4