-
Notifications
You must be signed in to change notification settings - Fork 6
Updates to README #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Updated instructions on installation Updated instructions on testing Added section on additional topics / known issues
|
Something that you might not be aware of is that the SessionInitializerFilter was added to Tomcat some time ago, so if you are using that server you do not need to add the additional jar in - you do still need to modify the web.xml file though: |
|
Wow... I never saw that post on the Lucee Dev forum. The jar that you're referring to is |
|
Yes, that is correct. If you are using Tomcat you do not need the additional jar. Just add the filter as described in the forum post. |
|
Good to know. I will update the document and re-push. |
cubiclabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that in the forum post about this, the filter class is different:
org.apache.catalina.filters.SessionInitializerFilter
instead of
net.twentyonesolutions.servlet.filter.HttpSessionInitializerFilter
This will be Tomcat only. I presume that for Jetty or other servers you will still need to add the jar and the original filter class. Not sure how best to explain that concisely in this readme though.
Add note about non-Tomcat servlet filter
|
@isapir Any comments on ths pull request? Do you know if / when it will get accepted / merged? Thanks! |
|
|
||
| --- | ||
| > <br/> | ||
| >💁🏼♀️ Watch the [Chart Server Example](https://www.youtube.com/watch?v=rvB7PcNylVY) tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should read "Chat Server Example".
|
@isapir Are you considering this project dead? :) |
Updated instructions on installation
Updated instructions on testing
Added section on additional topics / known issues