generated from isamplesorg/python_template
-
Notifications
You must be signed in to change notification settings - Fork 1
Add lossless PQG (Property Graph) conversion for GeoParquet exports #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rdhyee
wants to merge
4
commits into
isamplesorg:develop
Choose a base branch
from
rdhyee:claude/convert-parquet-to-pqg-01XnZwcYiRMwmpmyjP9FBmJN
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
545fd5c
Add PQG (Property Graph) conversion for iSamples GeoParquet exports
claude 4f7bfe4
Make PQG conversion lossless - preserve all iSamples fields
claude a64dadc
Add detailed answers to lossiness and PostgreSQL questions
claude a902940
Fix GitHub Actions workflow and address Copilot feedback
rdhyee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,60 @@ | ||
| # This workflow will install Python dependencies, run tests and lint with a single version of Python | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/using-python-with-github-actions | ||
|
|
||
| name: Python unit tests | ||
| name: Python unit tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: [ develop ] | ||
| pull_request: | ||
| branches: [ develop ] | ||
| workflow_dispatch: | ||
| on: | ||
| push: | ||
| branches: [ develop ] | ||
| pull_request: | ||
| branches: [ develop ] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| build: | ||
| jobs: | ||
| build: | ||
|
|
||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.11] | ||
|
|
||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| matrix: | ||
| python-version: [3.11] | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 | ||
| with: | ||
| submodules: recursive | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v2 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install Poetry | ||
| uses: snok/install-poetry@v1 | ||
| with: | ||
| virtualenvs-create: true | ||
| virtualenvs-in-project: true | ||
| - name: Cache Poetry virtualenv | ||
| id: cache | ||
| uses: actions/cache@v2 | ||
| with: | ||
| path: .venv | ||
| key: venv-${{ runner.os }}-#{{ hashFiles('**/poetry.lock') }} | ||
| - name: install pip | ||
| run: poetry run python -m pip install --upgrade pip | ||
| - name: Install | ||
| if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' | ||
| run: poetry install --no-interaction | ||
| - name: Test with pytest | ||
| working-directory: ./tests | ||
| run: | | ||
| source ../.venv/bin/activate | ||
| pytest | ||
| - name: flake8 linter | ||
| run: | | ||
| source ./.venv/bin/activate | ||
| python -m flake8 --count --max-complexity 10 --ignore E501,W503 --show-source --statistics --exclude ./.venv . | ||
| - name: Run mypy | ||
| run: | | ||
| source ./.venv/bin/activate | ||
| pip install mypy | ||
| mypy --install-types --non-interactive --namespace-packages | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| submodules: recursive | ||
| - name: Set up Python ${{ matrix.python-version }} | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} | ||
| - name: Install Poetry | ||
| uses: snok/install-poetry@v1 | ||
| with: | ||
| virtualenvs-create: true | ||
| virtualenvs-in-project: true | ||
| - name: Cache Poetry virtualenv | ||
| id: cache | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: .venv | ||
| key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }} | ||
| - name: install pip | ||
| run: poetry run python -m pip install --upgrade pip | ||
| - name: Install | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: poetry install --no-interaction | ||
| - name: Test with pytest | ||
| working-directory: ./tests | ||
| run: | | ||
| source ../.venv/bin/activate | ||
| pytest | ||
| - name: flake8 linter | ||
| run: | | ||
| source ./.venv/bin/activate | ||
| python -m flake8 --count --max-complexity 10 --ignore E501,W503 --show-source --statistics --exclude ./.venv . | ||
| - name: Run mypy | ||
| run: | | ||
| source ./.venv/bin/activate | ||
| pip install mypy | ||
| mypy --install-types --non-interactive --namespace-packages |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of node types is incomplete - it mentions 7 node types but omits
RelatedResource. According to the code and the note at line 246, there are 8 node types: Sample, SamplingEvent, SamplingSite, Location, Category, Curation, Agent, and RelatedResource. Please add RelatedResource to this list.