Open
Conversation
zougloub
suggested changes
Feb 5, 2018
zougloub
left a comment
zougloub
left a comment
There was a problem hiding this comment.
I was just looking at the repo code, and thought I'd comment on the PR.
| pass | ||
| client_host, client_port = self.client_address | ||
| client_host = self.client_address[0] | ||
| client_port = self.client_address[1] |
| class DHTServer(SocketServer.ThreadingMixIn, SocketServer.UDPServer): | ||
| def __init__(self, host_address, handler_cls): | ||
| def __init__(self, host_address, handler_cls, ipv6): | ||
| self.address_family = socket.AF_INET6 if ipv6 else socket.AF_INET |
|
|
||
| class DHTServer(SocketServer.ThreadingMixIn, SocketServer.UDPServer): | ||
| def __init__(self, host_address, handler_cls): | ||
| def __init__(self, host_address, handler_cls, ipv6): |
There was a problem hiding this comment.
To keep the API functional, should use a default parameter.
| def __init__(self, host, port, id=None, boot_host=None, boot_port=None): | ||
| if not id: | ||
| id = random_id() | ||
| ipv6 = True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed IPV6 for some tests so did an update